Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConditionSeverityError only if the error is non-transient #3017

Closed
sedefsavas opened this issue Dec 10, 2021 · 1 comment · Fixed by #3018
Closed

Use ConditionSeverityError only if the error is non-transient #3017

sedefsavas opened this issue Dec 10, 2021 · 1 comment · Fixed by #3018
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@sedefsavas
Copy link
Contributor

Some conditions are set incorrectly to false with error severity, even if the failures are transient.
Transient failures mostly happen during the cluster creation, and when AWSCluster conditions are set to false with Error severity, it bubbles up to Cluster Ready() condition with error severity and could be interpreted as an unrecoverable error.

We should set transient errors with Warning severity.

Example (left side is Cluster and right side is AWSCluster):

image

@k8s-ci-robot
Copy link
Contributor

@sedefsavas: This issue is currently awaiting triage.

If CAPA/CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 10, 2021
@sedefsavas sedefsavas added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Dec 10, 2021
@sedefsavas sedefsavas added this to the v1.2.0 milestone Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
2 participants