findSubnet function's logic is incorrect when subnet ID is specified

[pydctw]

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]

findSubnet function's logic is incorrect when subnet ID is specified in AWSMachine's spec. Current logic returns a subnet ID from a spec when failureDomain is not defined, which may not match any subnets provided in AWSCluster.

What did you expect to happen:
The function should find a matching subnet regardless of a failureDomain setting.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

• Cluster-api-provider-aws version:
• Kubernetes version: (use kubectl version):
• OS (e.g. from /etc/os-release):

[Ankitasw]

/priority important-soon
/assign @pydctw

[Ankitasw]

/lifecycle active

[richardcase]

Fixed in #2728 so:

/close

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[sedefsavas]

Already fixed.