Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Flatcar linux for nodes #1979

Closed
richardcase opened this issue Sep 28, 2020 · 15 comments · Fixed by #2271
Closed

Support Flatcar linux for nodes #1979

richardcase opened this issue Sep 28, 2020 · 15 comments · Fixed by #2271
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@richardcase
Copy link
Member

/kind feature

Describe the solution you'd like
I would like to be able to use Flatcar linux for the control plane and worker nodes with CAPA.

Anything else you would like to add:
Documentation for running flatcar on ec2 is here. There are existing AMIs that can be used but we'd need to think about the ignition and kubeadm config.

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 28, 2020
@ncdc
Copy link
Contributor

ncdc commented Sep 29, 2020

@vbatts
Copy link

vbatts commented Nov 4, 2020

Having a provider like CAPA would be a good use case to test the WIP Ignition bootstrap provider in kubernetes-sigs/cluster-api#3437

@randomvariable randomvariable added this to the v0.7.0 milestone Nov 9, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2021
@richardcase
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2021
@invidian
Copy link
Member

See #1875 (comment) for some progress update.

@invidian
Copy link
Member

Created #2271 with initial implementation to resolve this and possibly #1875.

@randomvariable randomvariable modified the milestones: v0.7.0, v0.6.x Mar 11, 2021
@invidian
Copy link
Member

Should this be moved to v0.7.0 milestone the same as #2271 ?

@randomvariable
Copy link
Member

Yup, thx.

/milestone v0.7.0

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 26, 2021
@invidian
Copy link
Member

/remove-lifecycle stale

We're doing a good progress on kubernetes-sigs/cluster-api#4172, we recently added missing e2e tests, a feature gate and documentation.

BTW, as CABPK decided that Ignition support will be behind a feature gate for the time being, how does it affect this PR? Can we enable the feature gate for e2e tests?

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 27, 2021
@sedefsavas
Copy link
Contributor

Adding ignition support directly to the API that uses an experimental feature in the core cluster-api repository may not be the best option. We should consider feature-gating it in this repository as well.

Can we enable the feature gate for e2e tests?

yes, we do it for other experimental feats:

EXP_CLUSTER_RESOURCE_SET: "true"

@invidian
Copy link
Member

Adding ignition support directly to the API that uses an experimental feature in the core cluster-api repository may not be the best option. We should consider feature-gating it in this repository as well.

We will do it, thanks for the advice, it make sense 👍 CC @surajssd

@randomvariable randomvariable modified the milestones: v0.7.x, v1.2.0 Nov 8, 2021
@invidian
Copy link
Member

invidian commented Dec 9, 2021

CABPK PR kubernetes-sigs/cluster-api#4172 has been merged and will be part of v1.1 release, so we're getting closer getting this resolved 🎉

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 9, 2022
@invidian
Copy link
Member

invidian commented Mar 9, 2022

/remove-lifecycle stale

This is still in progress.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 9, 2022
@t-lo t-lo mentioned this issue Jan 4, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants