Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tags package (specifically Apply) #1843

Closed
richardcase opened this issue Jul 27, 2020 · 2 comments · Fixed by #1848
Closed

Refactor tags package (specifically Apply) #1843

richardcase opened this issue Jul 27, 2020 · 2 comments · Fixed by #1848
Assignees
@richardcase
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.5.x

Comments

@richardcase
Copy link
Member

/kind feature

Describe the solution you'd like
The tags package is used throughout the services to apply infrav1.Tags to resources created in AWS. The current implementation in the tags package is very EC2 specific:

https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/master/pkg/cloud/tags/tags.go#L36

So it would be good to refactor this so that other services can take advantage of the tags differencing (and apply) functionality.

Anything else you would like to add:
This will help with #1787 in a tags only update scenario.

Environment:

  • Cluster-api-provider-aws version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 27, 2020
@richardcase
Copy link
Member Author

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jul 27, 2020
@richardcase richardcase mentioned this issue Jul 27, 2020
Closed
13 tasks
@detiber
Copy link
Member

detiber commented Jul 27, 2020

/milestone v0.5.x
/priority important-soon

@k8s-ci-robot k8s-ci-robot added this to the v0.5.x milestone Jul 27, 2020
@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jul 27, 2020
@richardcase richardcase mentioned this issue Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richardcase richardcase

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.5.x
Development

Successfully merging a pull request may close this issue.

🌱 refactor tags package to support other services
3 participants
@richardcase @detiber @k8s-ci-robot