Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement correct upgrade procedure for provider manifest #404

Closed
Danil-Grigorev opened this issue Jan 23, 2024 · 2 comments · Fixed by #399
Closed

Implement correct upgrade procedure for provider manifest #404

Danil-Grigorev opened this issue Jan 23, 2024 · 2 comments · Fixed by #399
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@Danil-Grigorev
Copy link
Member

What steps did you take and what happened:
Currently, if a user changes version of the provider manifest, old components are getting removed, and new ones for the version are installed. This process does not include CRD migration.

Additionally, if the provider spec hash changes, then this triggers same logic, forcing a full re-apply of infrastructure.

What did you expect to happen:

  • CRD migration (prevent issues similar to this)
  • Align with clusterctl on how to act when provider version changes.
    • Installed version matches expected version - install current modified manifests.
    • Version differs - execute clusterctl upgrade procedure.
    • Provider is getting deleted - remove deployed manifests from the cluster.

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 23, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPI Operator contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Danil-Grigorev
Copy link
Member Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants