-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Azure availability zones #57
Conversation
docs/using-availability-zones.md
Outdated
} | ||
``` | ||
|
||
If topology-aware provisioning feature is used, feature gates `VolumeScheduling` and `DynamicProvisioningScheduling` should be enabled on master components (e.g. kube-apiserver, kube-controller-manager and kube-scheduler). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've removed the DynamicProvisioningScheduling feature gate in 1.12. So only VolumeScheduling is required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, thanks for tip
docs/using-availability-zones.md
Outdated
Zone-aware and topology-aware provisioning are supported for Azure managed disks. To support these features, a few options are added in AzureDisk storage class: | ||
|
||
- **zoned**: indicates whether new disks are provisioned with AZ. Default is true. | ||
- **zone** and **zones**: indicates which zones should be used to provision new disks (zone-aware provisioning). Only can be set if `zoned` is not false and allowedTopologies is not set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering that we are deprecating the zone/zones parameters for aws/gce in 1.12, replacing it with allowedTopologies which is beta, and this is just newly being introduced for azure as alpha, do you want to consider leaving it out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, let me remove it from this usage guide
|
||
Zone-aware and topology-aware provisioning are supported for Azure managed disks. To support these features, a few options are added in AzureDisk storage class: | ||
|
||
- **zoned**: indicates whether new disks are provisioned with AZ. Default is true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cause backwards compatibility issues for users that have StorageClasses before this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, azure supports both zoned and unzoned nodes together. If there's no zoned nodes in the cluster, then the disks will still be provisioned without zone.
@@ -0,0 +1,220 @@ | |||
# Availability Zones | |||
|
|||
**Feature Status:** Alpha since v1.12. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a feature gate that users have to set to enable this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noop, this is enabled for v1.12, so that new zoned nodes could be joined easily after upgrading an existing cluster.
docs/using-availability-zones.md
Outdated
Zone-aware and topology-aware provisioning are supported for Azure managed disks. To support these features, a few options are added in AzureDisk storage class: | ||
|
||
- **zoned**: indicates whether new disks are provisioned with AZ. Default is true. | ||
- **allowedTopologies**: indicates which topologies are allowed for topology-aware provisioning. Only can be set if `zoned` is not false and `zone`/`zones` are not set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, fixed now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…-leader-election-lost-openshift OCPBUGS-8474: CCM should not panic when losing leader election lease
Add docs for AZ: kubernetes/enhancements#586.
/assign @justaugustus