-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use file metadata for vhd disk lock #193
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix test failure
/test pull-azurefile-csi-driver-sanity |
hi @chewong did you hit this delete resource group timeout issue before?
|
No I haven't. Let's try re-testing it again. |
Looks like I need to upgrade go-autorest to a higher version: |
/hold cancel |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enables
ControllerPublishVolume
andControllerUnpublishVolume
, and use file metadata for vhd disk lock.Ideally we should use lease to lock to prevent race condition, while that API may be not ready yet, so we use metadata for locking first.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note:
/hold
hold for testing first