Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use file metadata for vhd disk lock #193

Merged
merged 7 commits into from
Mar 11, 2020
Merged

feat: use file metadata for vhd disk lock #193

merged 7 commits into from
Mar 11, 2020

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR enables ControllerPublishVolume and ControllerUnpublishVolume, and use file metadata for vhd disk lock.

Ideally we should use lease to lock to prevent race condition, while that API may be not ready yet, so we use metadata for locking first.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

feat: use file metadata for vhd disk lock

/hold
hold for testing first

@andyzhangx andyzhangx requested a review from ZeroMagic March 9, 2020 06:31
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2020
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer March 9, 2020 06:31
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 9, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 9, 2020
@andyzhangx
Copy link
Member Author

/test pull-azurefile-csi-driver-sanity

@andyzhangx
Copy link
Member Author

hi @chewong did you hit this delete resource group timeout issue before?

https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_azurefile-csi-driver/193/pull-azurefile-csi-driver-sanity/1237027955788484614/build-log.txt

2020/03/09 14:55:26 Deleting resource group azurefile-csi-driver-test-a59c174a-6215-11ea-9bf6-4e5f9aa97dbc
panic: test timed out after 10m0s

goroutine 53 [running]:
testing.(*M).startAlarm.func1()
	/usr/local/go/src/testing/testing.go:1377 +0xdf
created by time.goFunc
	/usr/local/go/src/time/sleep.go:168 +0x44

goroutine 1 [chan receive, 9 minutes]:
testing.(*T).Run(0xc000132200, 0x99a955, 0xa, 0x9bea60, 0x4890f6)
	/usr/local/go/src/testing/testing.go:961 +0x377
testing.runTests.func1(0xc000132100)
	/usr/local/go/src/testing/testing.go:1202 +0x78
testing.tRunner(0xc000132100, 0xc000143dc0)
	/usr/local/go/src/testing/testing.go:909 +0xc9
testing.runTests(0xc0000d6600, 0xda5240, 0x1, 0x1, 0x0)
	/usr/local/go/src/testing/testing.go:1200 +0x2a7
testing.(*M).Run(0xc000130180, 0x0)
	/usr/local/go/src/testing/testing.go:1117 +0x176
main.main()
	_testmain.go:44 +0x135

goroutine 20 [select]:
github.com/Azure/go-autorest/autorest.DelayForBackoffWithCap(0x37e11d600, 0x0, 0x0, 0xc0000ae240, 0xc00015e580)
	/home/prow/go/pkg/mod/github.com/!azure/go-autorest/[email protected]/sender.go:405 +0x14a
github.com/Azure/go-autorest/autorest.DelayForBackoff(...)
	/home/prow/go/pkg/mod/github.com/!azure/go-autorest/[email protected]/sender.go:391
github.com/Azure/go-autorest/autorest/azure.(*Future).WaitForCompletionRef(0xc00018fb30, 0xa52ec0, 0xc0000c6010, 0xa48820, 0xc0000b9cd0, 0xa48b40, 0xc00016e840, 0x0, 0x0, 0xdf8475800, ...)
	/home/prow/go/pkg/mod/github.com/!azure/go-autorest/[email protected]/azure/async.go:196 +0x333
sigs.k8s.io/azurefile-csi-driver/test/utils/azure.(*Client).DeleteResourceGroup(0xc000174000, 0xa52ec0, 0xc0000c6010, 0xc000118100, 0x3e, 0x28, 0xc000092900)
	/home/prow/go/src/sigs.k8s.io/azurefile-csi-driver/test/utils/azure/azure_helpers.go:97 +0x369
sigs.k8s.io/azurefile-csi-driver/test/sanity.TestSanity.func2(0xc000145880, 0xc000174000, 0xa52ec0, 0xc0000c6010, 0xc000132200)
	/home/prow/go/src/sigs.k8s.io/azurefile-csi-driver/test/sanity/sanity_test.go:61 +0xe7
sigs.k8s.io/azurefile-csi-driver/test/sanity.TestSanity(0xc000132200)
	/home/prow/go/src/sigs.k8s.io/azurefile-csi-driver/test/sanity/sanity_test.go:90 +0x7ca
testing.tRunner(0xc000132200, 0x9bea60)
	/usr/local/go/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
	/usr/local/go/src/testing/testing.go:960 +0x350

@chewong
Copy link
Member

chewong commented Mar 9, 2020

No I haven't. Let's try re-testing it again.
/retest

@andyzhangx
Copy link
Member Author

Looks like I need to upgrade go-autorest to a higher version:
Azure/go-autorest#357

@andyzhangx
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2020
@andyzhangx andyzhangx merged commit a78a68e into master Mar 11, 2020
@andyzhangx andyzhangx deleted the lock branch March 11, 2020 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants