Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only list specific file share snapshot in CreateSnapshot to reduce get file share throttling using management API #2152

Closed
andyzhangx opened this issue Oct 25, 2024 · 0 comments · Fixed by #2153
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@andyzhangx
Copy link
Member

andyzhangx commented Oct 25, 2024

Is your feature request related to a problem?/Why is this needed

Currently we list all file shares under one storage account, we could only list specific file share snapshot in CreateSnapshot, that could could reduce the get file share throttling further more

listSnapshot, err := d.cloud.FileClient.WithSubscriptionID(subsID).ListFileShare(ctx, rgName, accountName, "", snapshotsExpand)

// List lists all shares.
// Parameters:
// resourceGroupName - the name of the resource group within the user's subscription. The name is case
// insensitive.
// accountName - the name of the storage account within the specified resource group. Storage account names
// must be between 3 and 24 characters in length and use numbers and lower-case letters only.
// maxpagesize - optional. Specified maximum number of shares that can be included in the list.
// filter - optional. When specified, only share names starting with the filter will be listed.
// expand - optional, used to expand the properties within share's properties. Valid values are: deleted,
// snapshots. Should be passed as a string with delimiter ','
func (client FileSharesClient) List(ctx context.Context, resourceGroupName string, accountName string, maxpagesize string, filter string, expand string) (result FileShareItemsPage, err error) {

this is a further improvement of #1694 which reduces the get file share throttling a little using management API

Describe the solution you'd like in detail

Describe alternatives you've considered

Additional context

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 25, 2024
@andyzhangx andyzhangx changed the title add list file share cache in CreateSnapshot only specific list file share in CreateSnapshot Oct 25, 2024
@andyzhangx andyzhangx changed the title only specific list file share in CreateSnapshot only list specific file share snapshot in CreateSnapshot Oct 25, 2024
@andyzhangx andyzhangx changed the title only list specific file share snapshot in CreateSnapshot only list specific file share snapshot in CreateSnapshot to reduce get file share throttling Oct 25, 2024
@andyzhangx andyzhangx changed the title only list specific file share snapshot in CreateSnapshot to reduce get file share throttling only list specific file share snapshot in CreateSnapshot to reduce get file share throttling using management API Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants