Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Helm chart directly from this repository to Public ECR #3880

Closed
bryantbiggs opened this issue Oct 3, 2024 · 5 comments
Closed

Publish Helm chart directly from this repository to Public ECR #3880

bryantbiggs opened this issue Oct 3, 2024 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@bryantbiggs
Copy link
Member

Is your feature request related to a problem?

  • Publish Helm chart directly from this repository to Public ECR

Describe the solution you'd like

  • Publish Helm chart directly from this repository to Public ECR so that we can remove the dependency on eks-charts

  • This chart should be published from this repository primarily due to 2 reasons:

    1. To deploy new versions of aws-load-balancer-controller artifacts in unison - both the image and the helm chart
    2. It is where the maintainers primarily operate and where users should come for feature requests, bugs/issues, documentation, etc.

The container image is already being published to Public ECR, the same should be done for the Helm chart which then allows both the image and the chart to be published together to Public ECR

We have opened a PR on the eks-charts repo to deprecate and remove this chart and direct users to this project going forward - aws/eks-charts#1172

Describe alternatives you've considered

  • None
@shraddhabang
Copy link
Collaborator

The new release has been cut on eks-charts. You should now be able to fetch the latest version.

@bryantbiggs
Copy link
Member Author

no no no 😅 - @shraddhabang this isn't about the latest version. this is about moving away from the chart being hosted on the GitHub created chart index to Public ECR, and then any future chart releases are published directly from this repository to Public ECR

For example - node-termination-handler now does this https://github.com/aws/aws-node-termination-handler/tree/main/config/helm/aws-node-termination-handler and we have been able to remove this from the eks-charts repository aws/eks-charts#1155

@shraddhabang
Copy link
Collaborator

Sorry my bad. Just realised I added comment on the wrong one. :D
Yes I have read this already. Sorry about the confusion. I will reopen this one.

@shraddhabang shraddhabang reopened this Oct 8, 2024
@shraddhabang shraddhabang added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 9, 2024
@oliviassss
Copy link
Collaborator

@bryantbiggs, hi we do not have plan to deprecate aws-load-balancer-controller chart from eks-chart as right now. Eventually we shall move to host our charts into public ECR, but it's not ready yet. And this will break users who relies on eks-chart to install the controller

@bryantbiggs
Copy link
Member Author

we do not have plan to deprecate aws-load-balancer-controller chart from eks-chart as right now.

understood, and thats why the issue - to get it on the teams radar. Charts need to start moving out of eks-charts and into their respectie repositories where the source artifacts live and the teams own and maintain. please re-open the issue so we can track this effort to start publishing the chart directly from this repository - cc @M00nF1sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants