-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Helm chart deployment #132
Conversation
Welcome @ArieLevs! |
Hi @ArieLevs. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I signed it |
/ok-to-test |
@ArieLevs seems CLA check is still complaining |
@jsafrane @justinsb btw, whats the next step, |
@leakingtapan Hi anything i can do to promote this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply. Please also update our e2e test to use the helm chat so that the chart is properly tested.
@leakingtapan |
You will need to replace kustomization (which I think it's okay). See here for an example |
OK then, just thought it should be in addition to kustomize and not replace it. |
Did you get a chance to update the e2e test? |
@leakingtapan |
@ArieLevs We are seeing similar issue here: kubernetes-sigs/aws-ebs-csi-driver#463 and we are still investigating the root cause. Thx for ur patience :) |
/retest |
Fixed by: #136 |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArieLevs, leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Is this a bug fix or adding new feature? feature
What is this PR about? / Why do we need it? adding aws-fsx-csi-driver helm deployment
What testing is done? none