release-1.2: Helm chart 2.0.0 with changelog #458
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature? new chart release
What is this PR about? / Why do we need it? releases chart 2.0.0 currently sitting in master branch. #406
What testing is done?
Install the existing chart 1.2.4 and try dynamic provisioning example
helm repo add aws-efs-csi-driver https://kubernetes-sigs.github.io/aws-efs-csi-driver/
helm repo update
helm upgrade --install aws-efs-csi-driver --namespace kube-system aws-efs-csi-driver/aws-efs-csi-driver
k apply -f ./examples/kubernetes/dynamic_provisioning/specs/
k exec -it efs-app -- cat /data/out
Upgrade to 2.0.0 (obviously this won't work if I set values that existed in old chart that were moved in new chart, hence major version got bumped from 1 to 2). and check example still works
helm upgrade --install aws-efs-csi-driver ./charts/aws-efs-csi-driver -n kube-system
k exec -it efs-app -- cat /data/out
Delete and recreate example and check it still works.
k delete -f ./examples/kubernetes/dynamic_provisioning/specs/
k apply -f ./examples/kubernetes/dynamic_provisioning/specs/
k exec -it efs-app -- cat /data/out