Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-1.2: Helm chart 2.0.0 with changelog #458

Merged
merged 1 commit into from
May 28, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented May 27, 2021

Is this a bug fix or adding new feature? new chart release

What is this PR about? / Why do we need it? releases chart 2.0.0 currently sitting in master branch. #406

What testing is done?
Install the existing chart 1.2.4 and try dynamic provisioning example
helm repo add aws-efs-csi-driver https://kubernetes-sigs.github.io/aws-efs-csi-driver/
helm repo update
helm upgrade --install aws-efs-csi-driver --namespace kube-system aws-efs-csi-driver/aws-efs-csi-driver
k apply -f ./examples/kubernetes/dynamic_provisioning/specs/
k exec -it efs-app -- cat /data/out

Upgrade to 2.0.0 (obviously this won't work if I set values that existed in old chart that were moved in new chart, hence major version got bumped from 1 to 2). and check example still works
helm upgrade --install aws-efs-csi-driver ./charts/aws-efs-csi-driver -n kube-system
k exec -it efs-app -- cat /data/out

Delete and recreate example and check it still works.
k delete -f ./examples/kubernetes/dynamic_provisioning/specs/
k apply -f ./examples/kubernetes/dynamic_provisioning/specs/
k exec -it efs-app -- cat /data/out

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 27, 2021
@kbasv
Copy link

kbasv commented May 28, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit c59550a into kubernetes-sigs:release-1.2 May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants