-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add podAnnotations to snapshotController StatefulSet #884
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @snstanton! |
Hi @snstanton. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CLA signed |
Pull Request Test Coverage Report for Build 2019
💛 - Coveralls |
/ok-to-test I thought our chart was being inconsistent naming it podAnnotations instead of just annotations like in some other places but I see now podAnnotations refers to the statefulset's pod instead of statefulset itself... You need to rebase just because the version got bumped |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: snstanton, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Looks like the lgtm label got removed by the rebase for the version number change. There were no other code changes. |
I'm not sure how to proceed. The PR was approved pending a rebase. I rebased, then the PR wasn't re-approved before it needs to be rebased again. |
/lgtm sorry about that |
Is this a bug fix or adding new feature?
New feature
What is this PR about? / Why do we need it?
This PR adds support for setting pod annotations on the snapshot controller. This is useful for fluent-bit logging annotations.