Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snapshot controller resources #791

Merged

Conversation

tirumerla
Copy link
Contributor

Is this a bug fix or adding new feature?

  • Fix to apply resource constraints to snapshot controller

What is this PR about? / Why do we need it?

What testing is done?

  • Updated resources for snapshot controller stateful set and deployed in EKS. Pods were deployed without any issues. Ran kubectl get po -A -o json | grep -B 3 -i '"resources": {},' to verify the resources have been properly populated to the pods.

@k8s-ci-robot
Copy link
Contributor

Hi @tirumerla. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot requested review from d-nishi and gnufied March 12, 2021 21:10
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 12, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1717

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.695%

Totals Coverage Status
Change from base Build 1714: 0.0%
Covered Lines: 1745
Relevant Lines: 2136

💛 - Coveralls

@tirumerla
Copy link
Contributor Author

/assign @wongma7

@wongma7
Copy link
Contributor

wongma7 commented Mar 15, 2021

/lgtm
/approve
/ok-to-test

ty

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tirumerla, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2021
@wongma7
Copy link
Contributor

wongma7 commented Mar 15, 2021

/test pull-aws-ebs-csi-driver-verify

@k8s-ci-robot k8s-ci-robot merged commit a4d4871 into kubernetes-sigs:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants