-
Notifications
You must be signed in to change notification settings - Fork 803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suffix amazonlinux image with -amazonlinux and push debian image to GitHub #639
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bd330c2
to
753d376
Compare
run: | | ||
DEB_PUSH_TAG="docker.pkg.github.com/$GITHUB_REPOSITORY/$IMAGE:$TAG" | ||
docker buildx build \ | ||
-t $DEB_PUSH_TAG \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this uses the cache from previous build step ($DEB_BUILD_TAG) . If not, there is no point to $DEB_BUILD_TAG/ $AL2_BUILD_TAG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I'm a little bit confused. What's the benefit of build steps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes it quicker to debug what failed. if build succeed but push step failed. etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from local testing the build step image is cached so IMO it makes sense to separate the two steps
Pull Request Test Coverage Report for Build 1341
💛 - Coveralls |
/lgtm |
@ayberk: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
I don't have permission to restart travis CI, but it is unrelated and not required for merge so I am manually merging. |
The arm build fails, I'll figure it out and send follow up
|
**Is this a bug fix or adding new feature?**fix
**What is this PR about? / Why do we need it?**To match cloudbuild.yaml https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/cloudbuild.yaml and in preparation for the next release v0.8.0, amazonlinux based images will be suffixed with -amazonlinux, like v0.8.0-amazonlinux. And debian based images will become the "default" unsuffixed v0.8.0.
At the same time, I noticed crazy-max/ghaction-docker-buildx@v3 was deprecated https://github.com/crazy-max/ghaction-docker-buildx so I rewrote the action to use docker's official github actions.
What testing is done? Not sure if testing is possible? given the extensive rewrite I want to test the new scrijpt but it doesn't seem possible without actually triggering the action. So I will check if the latest tag was successfully pushed after this PR and if not will need a follow-up...