Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markdown issue in README.md #579

Merged

Conversation

ialidzhikov
Copy link
Contributor

Is this a bug fix or adding new feature?
/kind documentation

What is this PR about? / Why do we need it?
Fix markdown issue in README.md.

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 4, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2020
@ialidzhikov
Copy link
Contributor Author

/assign @wongma7 @ayberk

@k8s-ci-robot
Copy link
Contributor

@ialidzhikov: GitHub didn't allow me to assign the following users: ayberk.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @wongma7 @ayberk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1253

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.134%

Totals Coverage Status
Change from base Build 1249: 0.0%
Covered Lines: 1574
Relevant Lines: 1940

💛 - Coveralls

@wongma7
Copy link
Contributor

wongma7 commented Oct 6, 2020

/ok-to-test
/lgtm
/approve
thanks

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@ialidzhikov
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-e2e-single-az

1 similar comment
@ialidzhikov
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-e2e-single-az

@ayberk
Copy link
Contributor

ayberk commented Oct 6, 2020

/test pull-aws-ebs-csi-driver-e2e-single-az

@ialidzhikov
Copy link
Contributor Author

/retest

@ialidzhikov
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-e2e-single-az

1 similar comment
@ialidzhikov
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-e2e-single-az

@ialidzhikov
Copy link
Contributor Author

@wongma7, any idea why pull-aws-ebs-csi-driver-e2e-single-az keeps failing? Issues with the cloudprovider account or with the tests/driver itself?

@ayberk
Copy link
Contributor

ayberk commented Oct 7, 2020

Tests are failing for io2, which we have recently started supporting. io2 volumes seem to take longer to become available than our wait time right now. Since we have intermittent successful runs, we can increase the timeout as a short term workaround.

@ayberk
Copy link
Contributor

ayberk commented Oct 7, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 10220a1 into kubernetes-sigs:master Oct 8, 2020
@ialidzhikov ialidzhikov deleted the nit/markdown-issue branch October 14, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants