Support IOPS parameter for IO1/IO2 volumes

[torredil]

What is this PR about? / Why do we need it?

• Support IOPS parameter for IO1/IO2 volumes.
• Support IOPSPerGB for GP3 volumes.
• Address Support fixed number of IOPs for IO2 Volumes  #1364.

What testing is done?

• make test
• CI

StorageClass
---------------------------
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: ebs-sc
provisioner: ebs.csi.aws.com
volumeBindingMode: WaitForFirstConsumer
parameters:
  csi.storage.k8s.io/fstype: ext4
  IOPS: "100"
  type: io2
---------------------------

**Old behavior**

$ kubectl describe pvc

Warning  ProvisioningFailed    2s (x3 over 5s)  ebs.csi.aws.com_ebs-csi-controller-756d5594dd-vgzsj_728a3701-f044-4021-bfaf-316189032728  failed to provision volume with StorageClass "ebs-sc": rpc error: code = Internal desc = Could not create volume "pvc-6ebcdc8f-0ab7-4e9a-9ee4-477c7cbb7d87": invalid combination of volume size 4 GB and iopsPerGB 0: the resulting IOPS 0 is too low for AWS, it must be at least 100

**New behavior**

$ kubectl describe pvc

Normal   ProvisioningSucceeded  3s                 ebs.csi.aws.com_ebs-csi-controller-58f67d8bfb-fm2m7_9ca56fcb-bcc9-4ba8-a2e3-872db5595932  Successfully provisioned volume pvc-36e7c4ac-00cd-4340-9517-f3b5bcac6da8

• Failure mode: specifying IOPS and IOPSPerGB StorageClass parameters.

StorageClass
---------------------------
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: ebs-sc
provisioner: ebs.csi.aws.com
volumeBindingMode: WaitForFirstConsumer
parameters:
  csi.storage.k8s.io/fstype: ext4
  IOPS: "100"
  IOPSPerGB: "100"
  type: io2
---------------------------

$ kubectl describe pvc

Warning  ProvisioningFailed    2s (x2 over 3s)  ebs.csi.aws.com_ebs-csi-controller-58f67d8bfb-fm2m7_9ca56fcb-bcc9-4ba8-a2e3-872db5595932  failed to provision volume with StorageClass "ebs-sc": rpc error: code = Internal desc = Could not create volume "pvc-2c35f4c6-cc22-48c1-8d40-3a42645b7ee3": invalid StorageClass paramaters; specify either IOPS or IOPSPerGb, not both

Signed-off-by: Eddie Torres [email protected]

[ConnorJC3]

Maybe iops handling should be unified across all volume types that support it? There's already a lot of duplicate code here that could be cleaned up, and what if a customer wants IOPsPerGB support on GP3 volumes?

[torredil]

@ConnorJC3 Good point, refactored this to clean up the duplication and unify iops handling across volume types.

[rdpsin]

You should update the docs as well.

[rdpsin]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rdpsin, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rdpsin,torredil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment