Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1182 quote extra tags arg #1198

Merged
merged 4 commits into from
Jun 8, 2022
Merged

1182 quote extra tags arg #1198

merged 4 commits into from
Jun 8, 2022

Conversation

Kaezon
Copy link
Contributor

@Kaezon Kaezon commented Apr 5, 2022

Is this a bug fix or adding new feature?
Bug fix for #1182

What is this PR about? / Why do we need it?
This fix add quotes around the extra-tags argument in order to prevent special characters such as ":" from breaking the manifest YAML after template rendering.

What testing is done?
Manual test with "helm template" to validate render output, as well as a live deployment to make sure a deployment would run with the offending tag value.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 5, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 5, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @Kaezon!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 5, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Kaezon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2022
@k8s-ci-robot k8s-ci-robot requested review from gtxu and vdhanan April 5, 2022 13:30
@Kaezon
Copy link
Contributor Author

Kaezon commented Apr 5, 2022

Trying to get the CLA taken care of ASAP

@gtxu
Copy link
Contributor

gtxu commented Apr 5, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2022
@Kaezon
Copy link
Contributor Author

Kaezon commented May 3, 2022

Finally got feedback from legal and signed the CLA. Sorry for the wait.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 3, 2022
@torredil torredil removed the request for review from vdhanan June 7, 2022 15:26
@torredil
Copy link
Member

torredil commented Jun 7, 2022

Thank you for your contribution :)
/lgtm
/hold

cc @gtxu @rdpsin

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@rdpsin
Copy link
Contributor

rdpsin commented Jun 7, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@torredil torredil self-requested a review June 8, 2022 22:13
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kaezon, rdpsin, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@torredil
Copy link
Member

torredil commented Jun 8, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit a0fb162 into kubernetes-sigs:master Jun 8, 2022
@Kaezon Kaezon deleted the 1182-quote-extra-tags-arg branch June 9, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants