Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gcr prow builld failing because docker missing --os-version #1020

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Aug 11, 2021

Is this a bug fix or adding new feature? /bug

What is this PR about? / Why do we need it? doing some wack a mole . the new build makle rule almost succeeded but failed at the manifest annotate step with unknown flag: --os-version https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/aws-ebs-csi-driver-push-images/1425539295917117440 . This new image version has a new docker version with the flag.

What testing is done?

$ docker run -it -e DOCKER_CLI_EXPERIMENTAL=enabled --entrypoint docker gcr.io/k8s-testimages/gcb-docker-gcloud:v20210722-085d930 manifest annotate --help
Unable to find image 'gcr.io/k8s-testimages/gcb-docker-gcloud:v20210722-085d930' locally
v20210722-085d930: Pulling from k8s-testimages/gcb-docker-gcloud
Digest: sha256:7187e4554771f7faf4399ac20efcb303e4b315082046c79e3ca6eeae79f1f1fb
Status: Downloaded newer image for gcr.io/k8s-testimages/gcb-docker-gcloud:v20210722-085d930

Usage:  docker manifest annotate [OPTIONS] MANIFEST_LIST MANIFEST

Add additional information to a local image manifest

EXPERIMENTAL:
  docker manifest annotate is an experimental feature.
  Experimental features provide early access to product functionality. These
  features may change between releases without warning, or can be removed from a
  future release. Learn more about experimental features in our documentation:
  https://docs.docker.com/go/experimental/

Options:
      --arch string           Set architecture
      --os string             Set operating system
      --os-features strings   Set operating system feature
      --os-version string     Set operating system version
      --variant string        Set architecture variant

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 11, 2021
@vdhanan
Copy link
Contributor

vdhanan commented Aug 19, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 19, 2021

/test pull-aws-ebs-csi-driver-external-test

@k8s-ci-robot k8s-ci-robot merged commit 8c6c7e0 into kubernetes-sigs:master Aug 19, 2021
k8s-ci-robot added a commit that referenced this pull request Sep 17, 2021
[release-1.2] Fix gcr prow and github builds: cherry-pick of #1016, #1017, and #1020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants