Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chart] Add controller strategy #1008

Merged
merged 1 commit into from
Aug 12, 2021
Merged

[chart] Add controller strategy #1008

merged 1 commit into from
Aug 12, 2021

Conversation

stevehipwell
Copy link
Contributor

Is this a bug fix or adding new feature?
This PR adds the ability to configure the controller update strategy.

What is this PR about? / Why do we need it?
With the default update strategy and tightly mapped zones the surge pods cause issues.

What testing is done?
Helm template output validated.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 3, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @stevehipwell. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from ayberk and ddebroy August 3, 2021 16:09
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 3, 2021
krmichel
krmichel suggested changes Aug 3, 2021
View reviewed changes
charts/aws-ebs-csi-driver/Chart.yaml Outdated
@@ -2,7 +2,7 @@ apiVersion: v2
appVersion: 1.2.0
name: aws-ebs-csi-driver
description: A Helm chart for AWS EBS CSI Driver
version: 2.0.4
version: 2.0.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is adding new features to the chart. The version should be 2.1.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure, a lot of PRs I've been doing recently have only be accepted as patches, will fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@stevehipwell stevehipwell force-pushed the add-controller-strategy branch from 24cf6d3 to 2a8cf94 Compare August 3, 2021 16:24
@stevehipwell
Copy link
Contributor Author

@vdhanan could you take a look at this?

@stevehipwell
Copy link
Contributor Author

/assign @jsafrane

@vdhanan
Copy link
Contributor

vdhanan commented Aug 10, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2021
@stevehipwell
[chart] Add controller strategy
2e5441d 
Signed-off-by: Steve Hipwell <[email protected]>
@stevehipwell stevehipwell force-pushed the add-controller-strategy branch from 2a8cf94 to 2e5441d Compare August 11, 2021 08:10
@stevehipwell
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-migration-test

@stevehipwell
Copy link
Contributor Author

@vdhanan tests are all passing, could you or @jsafrane take a look at getting this merged?

@vdhanan
Copy link
Contributor

vdhanan commented Aug 11, 2021

/lgtm
/approve

@vdhanan
Copy link
Contributor

vdhanan commented Aug 11, 2021

thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krmichel, stevehipwell, vdhanan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2021
@stevehipwell
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-e2e-single-az

@stevehipwell
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-external-test-eks

@k8s-ci-robot k8s-ci-robot merged commit cec968b into kubernetes-sigs:master Aug 12, 2021
@stevehipwell stevehipwell deleted the add-controller-strategy branch August 12, 2021 09:04
@stevehipwell stevehipwell mentioned this pull request Oct 18, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krmichel krmichel krmichel approved these changes

@ayberk ayberk Awaiting requested review from ayberk

@ddebroy ddebroy Awaiting requested review from ddebroy

Assignees

@jsafrane jsafrane

@vdhanan vdhanan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stevehipwell @k8s-ci-robot @vdhanan @krmichel @jsafrane