Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart v2.15.0 is creating testing resources during helm install #1476

Closed
robinkb opened this issue Jan 12, 2023 · 2 comments · Fixed by #1477
Closed

Helm chart v2.15.0 is creating testing resources during helm install #1476

robinkb opened this issue Jan 12, 2023 · 2 comments · Fixed by #1477
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@robinkb
Copy link

robinkb commented Jan 12, 2023

/kind bug

What happened?

Running a diff to upgrade our aws-ebs-csi-driver Helm chart to v2.15.0 shows that it is creating resources that are used for testing. These resources were introduced in #1454. The resources are located in charts/aws-ebs-csi-driver/templates/tests/helm-tester.yaml.

What you expected to happen?

The chart does not deploy resources related to testing unless I run helm test.

How to reproduce it (as minimally and precisely as possible)?

Run helm template against chart version 2.15.0. Resources like a ServiceAccount named helm-sa will be rendered.

Anything else we need to know?:

I'm not very familiar with how Helm's test mechanisms, but I think that they are missing the helm.sh/hook: test annotation. The Pod is marked with this annotation, and is not being created.

Environment

Not relevant.

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 12, 2023
@robinkb robinkb changed the title Helm chart v2.15.0 is creating testing resources Helm chart v2.15.0 is creating testing resources during helm install Jan 12, 2023
@ConnorJC3
Copy link
Contributor

ConnorJC3 commented Jan 12, 2023

Hey, sorry about that! We're pushing out a new release that adds the hook annotation - should be available as soon as CI finishes on #1477 as v2.15.1

@robinkb
Copy link
Author

robinkb commented Jan 13, 2023

Thanks for the very quick response! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants