Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm Chart][Feature] Allow Setting Custom imagePullPolicy for csi-resizer #1040

Closed
jyaworski opened this issue Sep 2, 2021 · 1 comment · Fixed by #1045
Closed

[Helm Chart][Feature] Allow Setting Custom imagePullPolicy for csi-resizer #1040

jyaworski opened this issue Sep 2, 2021 · 1 comment · Fixed by #1045

Comments

@jyaworski
Copy link
Contributor

Is your feature request related to a problem?/Why is this needed
We cache images on our worker nodes and would like to use that cache when possible. imagePullPolicy: Always doesn't allow us to do that.

/feature

Describe the solution you'd like in detail
I would like to have the ability to set the CSI Resizer imagePullPolicy.

Describe alternatives you've considered
None

Additional context
I can file a PR for this myself, if it's approved.

https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/charts/aws-ebs-csi-driver/templates/controller.yaml#L215

@wongma7
Copy link
Contributor

wongma7 commented Sep 2, 2021

yes feel free to file a PR to remove this line, I am not sure why it is there when all the other sidecars don't specify an imagePullPolicy, the PR will be approved.

(in addition, I suppose each sidecar should have a sidecars.*.pullPolicy field. But removing this line does not preclude adding a a sidecars.*.pullPolicy field later.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants