Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules controller #664

Merged
merged 18 commits into from
Oct 9, 2018
Merged

Rules controller #664

merged 18 commits into from
Oct 9, 2018

Conversation

bigkraig
Copy link

@bigkraig bigkraig commented Oct 4, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigkraig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 4, 2018
@coveralls
Copy link

coveralls commented Oct 4, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.09%) to 35.543% when pulling 62002db on rule-refactor into b3b52f1 on master.

M00nF1sh
M00nF1sh reviewed Oct 5, 2018
View reviewed changes
internal/alb/rs/rules.go Outdated
if i < 0 {
return nil, fmt.Errorf("failed to find a target group associated with a rule. This should not be possible. Rule: %s, ARN: %s", awsutil.Prettify(r.RuleArn), *r.Actions[0].TargetGroupArn)
func (rs *Rules) TargetGroupArns() (result []string) {
for _, rule := range rs.Rules {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we need to reply these arns to know which target group we need.
Since when we build these target groups, we already know it. (this can be changed later when we refactoring more)

M00nF1sh
M00nF1sh reviewed Oct 5, 2018
View reviewed changes
internal/alb/rs/rules.go Outdated
if rule.rs.current == nil {
continue TG
func (c *rulesController) getCurrentRules(listenerArn string) (results []*Rule, err error) {
p := request.Pagination{
Copy link
Collaborator

@M00nF1sh M00nF1sh Oct 5, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not deal with terrible aws pagination api in application logic(which makes the unit test/code logic hard).
Instead, i'd prefer to create a wrapper api in elbv2 that returns a list of rules directly.

@bigkraig bigkraig changed the title WIP: Rules controller Rules controller Oct 5, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 5, 2018
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Oct 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2018
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Oct 9, 2018

i guess you have to close & reopen this pr to trigger travis again 😸

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@bigkraig
Copy link
Author

bigkraig commented Oct 9, 2018

@M00nF1sh I rebased it on master but its going to need another lgtm

@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Oct 9, 2018

/lgtm
😄

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 9, 2018
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Oct 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@M00nF1sh
Copy link
Collaborator

M00nF1sh commented Oct 9, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2018
@bigkraig
Copy link
Author

bigkraig commented Oct 9, 2018

/override coverage/coveralls

@k8s-ci-robot k8s-ci-robot merged commit e568a20 into master Oct 9, 2018
@M00nF1sh M00nF1sh mentioned this pull request Nov 28, 2018
Closed
@bigkraig bigkraig deleted the rule-refactor branch March 22, 2019 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M00nF1sh M00nF1sh M00nF1sh left review comments

Assignees

@M00nF1sh M00nF1sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bigkraig @k8s-ci-robot @coveralls @M00nF1sh