This repository has been archived by the owner on May 6, 2022. It is now read-only.
Use correct infof calls in controller_manager #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
arschles
reviewed
Jun 19, 2017
| @@ -1,5 +1,5 @@ | |||
| {{- if .Values.useAggregator }} | |||
| apiVersion: apiregistration.k8s.io/v1alpha1 | |||
| apiVersion: apiregistration.k8s.io/v1beta1 | |||
There was a problem hiding this comment.
did this ever work on 1.6? I never tried it
|
No, that should not be part of the change set :)
…On Mon, Jun 19, 2017 at 6:22 PM, Aaron Schlesinger ***@***.*** > wrote:
***@***.**** commented on this pull request.
LGTM pending one question
------------------------------
In charts/catalog/templates/apiregistration.yaml
<#950 (comment)>
:
> @@ -1,5 +1,5 @@
{{- if .Values.useAggregator }}
-apiVersion: apiregistration.k8s.io/v1alpha1
+apiVersion: apiregistration.k8s.io/v1beta1
did this ever work on 1.6? I never tried it
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#950 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWXmAQTsYzNH1-0XmQ7_uLFCatct1Gtks5sFvStgaJpZM4N-3FK>
.
|
MHBauer
approved these changes
Jun 19, 2017
|
changed my mind. we should use outfof. /badjoke |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a couple places we were incorrectly calling
Infoinstead ofInfof