This repository has been archived by the owner on May 6, 2022. It is now read-only.
Fix make verify
#2788
Merged
Fix make verify
#2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few things are causing the `make verify` command (and subsequently `make`) to fail. These are addressed in this commit, as follows: 1. `make verify-docs` - Explicitely skip the localhost link in contribute/docs.md and remove a link for a non-yet-existent repository in pkg/kubernetes/README.md. 1. Exclude `bin/verify-links.sh` from the `verify-boilerplate.sh` check (this file is .gitignored) 1. Update GO_VERSION defined in the Makefile to match GO_VERSION defined in .travis.yml Addresses an issue mentioned in kubernetes-retired#2782.
|
Hi @teddyking. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jberkhahn, teddyking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
gmrodgers
pushed a commit
to gmrodgers/service-catalog
that referenced
this pull request
Mar 27, 2020
A few things are causing the `make verify` command (and subsequently `make`) to fail. These are addressed in this commit, as follows: 1. `make verify-docs` - Explicitely skip the localhost link in contribute/docs.md and remove a link for a non-yet-existent repository in pkg/kubernetes/README.md. 1. Exclude `bin/verify-links.sh` from the `verify-boilerplate.sh` check (this file is .gitignored) 1. Update GO_VERSION defined in the Makefile to match GO_VERSION defined in .travis.yml Addresses an issue mentioned in kubernetes-retired#2782.
gmrodgers
pushed a commit
to gmrodgers/service-catalog
that referenced
this pull request
Mar 27, 2020
A few things are causing the `make verify` command (and subsequently `make`) to fail. These are addressed in this commit, as follows: 1. `make verify-docs` - Explicitely skip the localhost link in contribute/docs.md and remove a link for a non-yet-existent repository in pkg/kubernetes/README.md. 1. Exclude `bin/verify-links.sh` from the `verify-boilerplate.sh` check (this file is .gitignored) 1. Update GO_VERSION defined in the Makefile to match GO_VERSION defined in .travis.yml Addresses an issue mentioned in kubernetes-retired#2782.
k8s-ci-robot
pushed a commit
that referenced
this pull request
Mar 27, 2020
…lasses` via a `--broker` flag (#2786) * Support filtering classes by broker in svcat * Fix `make verify` (#2788) A few things are causing the `make verify` command (and subsequently `make`) to fail. These are addressed in this commit, as follows: 1. `make verify-docs` - Explicitely skip the localhost link in contribute/docs.md and remove a link for a non-yet-existent repository in pkg/kubernetes/README.md. 1. Exclude `bin/verify-links.sh` from the `verify-boilerplate.sh` check (this file is .gitignored) 1. Update GO_VERSION defined in the Makefile to match GO_VERSION defined in .travis.yml Addresses an issue mentioned in #2782. * Update ups-broker docs link to point to chart on github. (#2790) Co-authored-by: Ed King <[email protected]> Co-authored-by: Mirah Gary <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things are causing the
make verifycommand (and subsequentlymake) tofail. These are addressed in this commit, as follows:
make verify-docs- Explicitely skip the localhost link incontribute/docs.md and remove a link for a non-yet-existent repository in
pkg/kubernetes/README.md.
bin/verify-links.shfrom theverify-boilerplate.shcheck (thisfile is .gitignored)
GO_VERSIONdefined in the Makefile to matchGO_VERSIONdefined in.travis.yml
These changes allow a developer to clone the repo, cd into it and run
makeand have it pass successfully.Addresses an issue mentioned in #2782.
This PR is a
Please leave this checklist in the PR comment so that maintainers can ensure a good PR.
Merge Checklist:
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update