fix: make allErrs complete in validateServiceClassSpec

[beautytiger]

This PR is a

• Feature Implementation
• Bug Fix
• Documentation

What this PR does / why we need it:

Which issue(s) this PR fixes

Fixes #

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

• New feature
  • Tests
  • Documentation
• SVCat CLI flag
• Server Flag for config
  • Chart changes
  • removing a flag by marking deprecated and hiding to avoid
    breaking the chart release and existing clients who provide a
    flag that will get an error when they try to update

[k8s-ci-robot]

Hi @beautytiger. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mszostok]

/ok-to-test

[mszostok]

nice catch, it's been here for almost 2 years :D

[k8s-ci-robot]

@beautytiger: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-service-catalog-test-e2e	37817b4	link	/test pull-service-catalog-test-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mszostok]

The e2e is not passing because there is a problem with Ginkgo and go 1.13: onsi/ginkgo#602

In general when running test with go 1.13 you cannot call flag.Parse() in init() function: golang/go#34443 (comment)

We didn't have any problem with that previously because we executed our tests with go 1.12 but just 19ago the both form test infra updated our image for running e2e tests: https://github.com/kubernetes/test-infra/blame/e36eb04fdc6565d695a0086906ac5c92df7fb10b/config/jobs/kubernetes-sigs/service-catalog/service-catalog-presubmits.yaml#L49

I will revert that change ASAP because the ginkgo is currently not compatible with go 1.13

[mszostok]

the e2e test failing because of problem described here: #2749 (comment)

this does not block the merging because provided fix is definitely valid.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: beautytiger, mszostok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mszostok]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment