change controller finalizer back to kubernetes-incubator

[jberkhahn]

as per the discussion in the meeting today

[jberkhahn]

/cc @mszostok

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkhahn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jberkhahn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mszostok]

/test pull-service-catalog-xbuild

[mszostok]

found one thing:

you should also change the test data, it's mocked (both returned responses and golden files), so tests didn't catch that by IMO we should also rename that to do not confuse others.

• testdata

[jberkhahn]

@mszostok that should fix it

[jberkhahn]

/test pull-service-catalog-unit

[MHBauer]

yea, this would definitely not be a compatible change.
Unfortunately, it probably means needing to have two code paths for a while.
Can brainstorm later if you want.

[mszostok]

@MHBauer during the SIG meeting we discuss to move this change to CRD migration tool.

Here is the migration scenario from api-server to CRDs: https://github.com/kyma-incubator/service-catalog/blob/crds-migration/docs/migration-apiserver-to-crds.md#details-of-an-upgrade-and-migration

so we can add just one step to replace the finalizer name before saving resources into etcd and starting the new controller image.

That should be quite easy to do, and additionally, we will have only one migration process instead of supporting two of them, wdyt?

[mszostok]

/lgtm