Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Make the building of our build image smarter per issue 2329 #2330

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

duglin
Copy link
Contributor

@duglin duglin commented Sep 10, 2018

Checks to see if the image is in our docker cache too, instead of just
looking for .scBuildImage

Closes: #2329

Signed-off-by: Doug Davis [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 10, 2018
Checks to see if the image is in our docker cache too, instead of just
looking for .scBuildImage

Closes: 2329

Signed-off-by: Doug Davis <[email protected]>
@duglin
Copy link
Contributor Author

duglin commented Sep 10, 2018

How do I see the error from the test? When I click on the link it says:
Unable to load build details from gs://kubernetes-jenkins/pr-logs/pull/kubernetes-incubator_service-catalog/2330/pull-service-catalog-xbuild/270

/test pull-service-catalog-xbuild

@jboyd01
Copy link
Contributor

jboyd01 commented Sep 10, 2018

works for me.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2018
@jberkhahn
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkhahn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2018
@k8s-ci-robot k8s-ci-robot merged commit 2ce3cfe into kubernetes-retired:master Sep 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Makefile needs to delete hidden .scBuildImage file if image doesn't exist in docker
4 participants