Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Remove unused function #2265

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

carolynvs
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 6, 2018
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 6, 2018
@duglin
Copy link
Contributor

duglin commented Aug 6, 2018

if its not used...
LGTM

@duglin
Copy link
Contributor

duglin commented Aug 6, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2018
@jboyd01
Copy link
Contributor

jboyd01 commented Aug 6, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jboyd01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2018
@jboyd01 jboyd01 added the LGTM2 label Aug 6, 2018
@duglin duglin added the LGTM1 label Aug 6, 2018
@k8s-ci-robot k8s-ci-robot merged commit 95c1201 into kubernetes-retired:master Aug 6, 2018
@MHBauer
Copy link
Contributor

MHBauer commented Aug 7, 2018

how about these?

$ gometalinter.v2 --disable-all --enable=unused ./pkg/controller
pkg/controller/controller_actions_test.go:46:6:warning: func checkUpdateActionType is unused (U1000) (unused)
pkg/controller/controller_actions_test.go:53:6:warning: type catalogClientAction is unused (U1000) (unused)
pkg/controller/controller_actions_test.go:61:6:warning: func getRuntimeObjectFromUpdateAction is unused (U1000) (unused)
pkg/controller/controller_actions_test.go:75:6:warning: func checkServiceInstance is unused (U1000) (unused)
pkg/controller/controller_actions_test.go:108:6:warning: type instanceDescription is unused (U1000) (unused)
pkg/controller/controller_actions_test.go:150:6:warning: func checkCatalogClientActions is unused (U1000) (unused)
pkg/controller/controller_actions_test.go:172:6:warning: type brokerClientAction is unused (U1000) (unused)
pkg/controller/controller_clusterservicebroker_test.go:66:3:warning: field err is unused (U1000) (unused)
pkg/controller/controller_instance.go:65:2:warning: const errorWithOngoingAsyncOperationMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:71:2:warning: const errorNonexistentServiceClassMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:75:2:warning: const errorDeletedClusterServiceClassMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:77:2:warning: const errorDeletedClusterServicePlanMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:79:2:warning: const errorDeletedServiceClassMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:81:2:warning: const errorDeletedServicePlanMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:85:2:warning: const errorInvalidDeprovisionStatusMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:1579:6:warning: func newServiceInstanceOrphanMitigationCondition is unused (U1000) (unused)
pkg/controller/controller_test.go:88:2:warning: const testServiceInstanceCredentialSecretName is unused (U1000) (unused)
pkg/controller/controller_test.go:2290:6:warning: func assertClassRemovedFromBrokerCatalogTrue is unused (U1000) (unused)
pkg/controller/controller_test.go:2309:6:warning: func assertPlanRemovedFromBrokerCatalogTrue is unused (U1000) (unused)
pkg/controller/controller_test.go:2360:6:warning: func assertServiceInstanceReadyTrue is unused (U1000) (unused)
pkg/controller/controller_test.go:2418:6:warning: func assertServiceInstanceConditionsCount is unused (U1000) (unused)
pkg/controller/controller_test.go:2520:6:warning: func expectServiceInstanceOrphanMitigationInProgressTrue is unused (U1000) (unused)
pkg/controller/controller_test.go:2524:6:warning: func expectServiceInstanceOrphanMitigationInProgressFalse is unused (U1000) (unused)
pkg/controller/controller_test.go:3029:6:warning: func assertServiceBindingReadyTrue is unused (U1000) (unused)
pkg/controller/controller_test.go:3077:6:warning: func assertServiceBindingReconciliationNotComplete is unused (U1000) (unused)
pkg/controller/controller_test.go:3283:6:warning: func assertServiceBindingErrorFetchingBinding is unused (U1000) (unused)
pkg/controller/controller_test.go:3296:6:warning: func assertServiceBindingErrorInjectingCredentials is unused (U1000) (unused)
pkg/controller/controller_test.go:3374:6:warning: func assertServiceBindingOrphanMitigationFailure is unused (U1000) (unused)
pkg/controller/controller_test.go:3409:6:warning: func assertServiceBindingAsyncOpInProgressFalse is unused (U1000) (unused)
pkg/controller/controller_test.go:3438:6:warning: func assertServiceBindingInProgressPropertiesUnchanged is unused (U1000) (unused)
pkg/controller/controller_test.go:3576:6:warning: func expectNumberOfClusterServiceBrokerActions is unused (U1000) (unused)

@duglin
Copy link
Contributor

duglin commented Aug 7, 2018

nice tool

@carolynvs carolynvs deleted the unused-function branch October 4, 2018 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. LGTM1 LGTM2 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants