This repository has been archived by the owner on May 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 382
Remove unused function #2265
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-retired:master
from
carolynvs:unused-function
Aug 6, 2018
Merged
Remove unused function #2265
k8s-ci-robot
merged 1 commit into
kubernetes-retired:master
from
carolynvs:unused-function
Aug 6, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
label
Aug 6, 2018
k8s-ci-robot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Aug 6, 2018
if its not used... |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jboyd01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Aug 6, 2018
how about these? $ gometalinter.v2 --disable-all --enable=unused ./pkg/controller
pkg/controller/controller_actions_test.go:46:6:warning: func checkUpdateActionType is unused (U1000) (unused)
pkg/controller/controller_actions_test.go:53:6:warning: type catalogClientAction is unused (U1000) (unused)
pkg/controller/controller_actions_test.go:61:6:warning: func getRuntimeObjectFromUpdateAction is unused (U1000) (unused)
pkg/controller/controller_actions_test.go:75:6:warning: func checkServiceInstance is unused (U1000) (unused)
pkg/controller/controller_actions_test.go:108:6:warning: type instanceDescription is unused (U1000) (unused)
pkg/controller/controller_actions_test.go:150:6:warning: func checkCatalogClientActions is unused (U1000) (unused)
pkg/controller/controller_actions_test.go:172:6:warning: type brokerClientAction is unused (U1000) (unused)
pkg/controller/controller_clusterservicebroker_test.go:66:3:warning: field err is unused (U1000) (unused)
pkg/controller/controller_instance.go:65:2:warning: const errorWithOngoingAsyncOperationMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:71:2:warning: const errorNonexistentServiceClassMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:75:2:warning: const errorDeletedClusterServiceClassMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:77:2:warning: const errorDeletedClusterServicePlanMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:79:2:warning: const errorDeletedServiceClassMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:81:2:warning: const errorDeletedServicePlanMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:85:2:warning: const errorInvalidDeprovisionStatusMessage is unused (U1000) (unused)
pkg/controller/controller_instance.go:1579:6:warning: func newServiceInstanceOrphanMitigationCondition is unused (U1000) (unused)
pkg/controller/controller_test.go:88:2:warning: const testServiceInstanceCredentialSecretName is unused (U1000) (unused)
pkg/controller/controller_test.go:2290:6:warning: func assertClassRemovedFromBrokerCatalogTrue is unused (U1000) (unused)
pkg/controller/controller_test.go:2309:6:warning: func assertPlanRemovedFromBrokerCatalogTrue is unused (U1000) (unused)
pkg/controller/controller_test.go:2360:6:warning: func assertServiceInstanceReadyTrue is unused (U1000) (unused)
pkg/controller/controller_test.go:2418:6:warning: func assertServiceInstanceConditionsCount is unused (U1000) (unused)
pkg/controller/controller_test.go:2520:6:warning: func expectServiceInstanceOrphanMitigationInProgressTrue is unused (U1000) (unused)
pkg/controller/controller_test.go:2524:6:warning: func expectServiceInstanceOrphanMitigationInProgressFalse is unused (U1000) (unused)
pkg/controller/controller_test.go:3029:6:warning: func assertServiceBindingReadyTrue is unused (U1000) (unused)
pkg/controller/controller_test.go:3077:6:warning: func assertServiceBindingReconciliationNotComplete is unused (U1000) (unused)
pkg/controller/controller_test.go:3283:6:warning: func assertServiceBindingErrorFetchingBinding is unused (U1000) (unused)
pkg/controller/controller_test.go:3296:6:warning: func assertServiceBindingErrorInjectingCredentials is unused (U1000) (unused)
pkg/controller/controller_test.go:3374:6:warning: func assertServiceBindingOrphanMitigationFailure is unused (U1000) (unused)
pkg/controller/controller_test.go:3409:6:warning: func assertServiceBindingAsyncOpInProgressFalse is unused (U1000) (unused)
pkg/controller/controller_test.go:3438:6:warning: func assertServiceBindingInProgressPropertiesUnchanged is unused (U1000) (unused)
pkg/controller/controller_test.go:3576:6:warning: func expectNumberOfClusterServiceBrokerActions is unused (U1000) (unused) |
nice tool |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.