This repository has been archived by the owner on May 6, 2022. It is now read-only.
Define common interfaces for cluster and namespaced classes and plans #2220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
carolynvs
requested review from
jboyd01 and
jeremyrickard
and removed request for
jberkhahn and
n3wscott
carolynvs
force-pushed
the
define-common-interface
branch
from
ee0e2a8 to
c88790b
Compare
|
/lgtm |
|
@carolynvs - travis doesn't appreciate your lack of copyright in the two new files. I didn't catch it in review. |
|
Sorry abut that, forgot to run |
carolynvs
force-pushed
the
define-common-interface
branch
from
c88790b to
5a9b76e
Compare
k8s-ci-robot
added
size/L
|
/lgtm |
jeremyrickard
approved these changes
Jul 20, 2018
|
/lgtm |
|
/label LGTM2 |
|
/approve |
|
/assign @carolynvs |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jboyd01, jeremyrickard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary groundwork for the svcat cli to deal with both
ClusterServiceBrokersandServiceBrokers. I expect that interface may expand to add more values from the common specs but for now I just wanted to get it defined so that the many issues for supporting namespaced brokers aren't blocked by a larger PR (#2116).