Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Add unit test for cmd/svcat/broker/describe_cmd.go #2179

Merged
merged 2 commits into from
Jul 23, 2018
Merged

Add unit test for cmd/svcat/broker/describe_cmd.go #2179

merged 2 commits into from
Jul 23, 2018

Conversation

jichenjc
Copy link
Contributor

@jichenjc jichenjc commented Jul 3, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2018
@k8s-ci-robot k8s-ci-robot requested review from luksa and n3wscott July 3, 2018 03:37
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2018
Add unit test for cmd/svcat/broker/describe_cmd.go to increase
test coverage
Copy link
Contributor

@staebler staebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2018
@jberkhahn
Copy link
Contributor

jberkhahn commented Jul 4, 2018

Hey there,

I'm in the middle of refactoring the interface between the cmd and pkg libraries for svcat as part of my PR to add a register broker command: #2162. I'd like to hold off on adding additional tests to cmd/svcat for now, as it will likely look quite a bit different in the near future.

@MHBauer MHBauer added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2018
@jichenjc
Copy link
Contributor Author

jichenjc commented Jul 4, 2018

ok, I will hold those for now , thanks for the comments

@jberkhahn jberkhahn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2018
@MHBauer
Copy link
Contributor

MHBauer commented Jul 17, 2018

/cc @jberkhahn @carolynvs

Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carolynvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2018
@carolynvs
Copy link
Contributor

@jichenjc Thank you for adding these tests! 💖

@carolynvs
Copy link
Contributor

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 23, 2018

@jichenjc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-service-catalog-xbuild a815c2b link /test pull-service-catalog-xbuild

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@carolynvs carolynvs merged commit 7c2fb3a into kubernetes-retired:master Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. LGTM1 LGTM2 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants