-
Notifications
You must be signed in to change notification settings - Fork 382
Add unit test for cmd/svcat/broker/describe_cmd.go #2179
Add unit test for cmd/svcat/broker/describe_cmd.go #2179
Conversation
pull origin
Add unit test for cmd/svcat/broker/describe_cmd.go to increase test coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Hey there, I'm in the middle of refactoring the interface between the cmd and pkg libraries for svcat as part of my PR to add a register broker command: #2162. I'd like to hold off on adding additional tests to cmd/svcat for now, as it will likely look quite a bit different in the near future. |
ok, I will hold those for now , thanks for the comments |
/cc @jberkhahn @carolynvs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carolynvs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jichenjc Thank you for adding these tests! 💖 |
/retest |
@jichenjc: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.