Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Adding ServicePlan Control Loops #2146

Merged

Conversation

jeremyrickard
Copy link
Contributor

For namespaced brokers, adding ServicePlan reconciliation control loops.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 21, 2018
@jeremyrickard jeremyrickard changed the title Adding ServicePlan Control Loops WIP: Adding ServicePlan Control Loops Jun 21, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2018
@@ -0,0 +1,108 @@
/*
Copyright 2017 The Kubernetes Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2018 copyright :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@eriknelson
Copy link
Contributor

eriknelson commented Jun 21, 2018

I can't see anything that would cause the failure in this; looks like another test fluke.

@jeremyrickard
Copy link
Contributor Author

/retest

1 similar comment
@carolynvs
Copy link
Contributor

/retest

@carolynvs
Copy link
Contributor

I am watching this and kicking until we get past the build timeouts.

@jeremyrickard Is this still WIP or should I just let you keep pushing more changes before babysitting it?

@jeremyrickard
Copy link
Contributor Author

@carolynvs no this needed to go after service classes. i'll rebase and then we can kick the tires again :)

For namespaced brokers, adding ServicePlan reconciliation control loops.
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: mhbauer

Assign the PR to them by writing /assign @mhbauer in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeremyrickard jeremyrickard changed the title WIP: Adding ServicePlan Control Loops Adding ServicePlan Control Loops Jun 25, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2018
@jeremyrickard
Copy link
Contributor Author

I resolved the conflicts with the editor but looks like that didn't work. Reworking now

@jeremyrickard jeremyrickard force-pushed the serviceplan-control-loop branch from ac596e1 to d347b12 Compare June 25, 2018 18:47
@jeremyrickard
Copy link
Contributor Author

/retest

@n3wscott n3wscott added the LGTM1 label Jun 28, 2018
@eriknelson eriknelson merged commit 3ae5a6d into kubernetes-retired:master Jul 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2 size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants