-
Notifications
You must be signed in to change notification settings - Fork 382
Adding ServicePlan Control Loops #2146
Adding ServicePlan Control Loops #2146
Conversation
@@ -0,0 +1,108 @@ | |||
/* | |||
Copyright 2017 The Kubernetes Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2018 copyright :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
I can't see anything that would cause the failure in this; looks like another test fluke. |
/retest |
1 similar comment
/retest |
I am watching this and kicking until we get past the build timeouts. @jeremyrickard Is this still WIP or should I just let you keep pushing more changes before babysitting it? |
@carolynvs no this needed to go after service classes. i'll rebase and then we can kick the tires again :) |
For namespaced brokers, adding ServicePlan reconciliation control loops.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I resolved the conflicts with the editor but looks like that didn't work. Reworking now |
ac596e1
to
d347b12
Compare
/retest |
For namespaced brokers, adding ServicePlan reconciliation control loops.