Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Verify builds on all platforms on master #2096

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

carolynvs
Copy link
Contributor

This is to avoid realizing too late (when we tag a release) that one of the supported architectures has a build problem. I didn't want to slow down all the PR builds, so I'm only doing this for master.

This is to avoid realizing too late (when we tag a release) that one of
the supported architectures has a build problem. I didn't want to slow
down all the PR builds, so I'm only doing this for master.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2018
Copy link
Contributor

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

LGTM

@MHBauer MHBauer added the LGTM1 label Jun 5, 2018
@carolynvs carolynvs force-pushed the run-xbuild-on-master branch from 80aa1ea to 2b162a0 Compare June 6, 2018 00:39
@carolynvs
Copy link
Contributor Author

I have verified that the new xbuild stage works in this PR, and removed the test commit.

@carolynvs carolynvs changed the title [WIP]Verify builds on all platforms on master Verify builds on all platforms on master Jun 6, 2018
@MHBauer
Copy link
Contributor

MHBauer commented Jun 7, 2018

testing
/lgtm
/woof

@k8s-ci-robot
Copy link
Contributor

@MHBauer: dog image

In response to this:

testing
/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2018
@jboyd01 jboyd01 added the LGTM2 label Jun 11, 2018
@jboyd01 jboyd01 merged commit ffe6502 into kubernetes-retired:master Jun 11, 2018
carolynvs pushed a commit to carolynvs/service-catalog that referenced this pull request Jun 14, 2018
carolynvs pushed a commit to carolynvs/service-catalog that referenced this pull request Jun 14, 2018
@carolynvs carolynvs mentioned this pull request Jun 14, 2018
kikisdeliveryservice pushed a commit to kikisdeliveryservice/service-catalog that referenced this pull request Jun 29, 2018
This is to avoid realizing too late (when we tag a release) that one of
the supported architectures has a build problem. I didn't want to slow
down all the PR builds, so I'm only doing this for master.
@carolynvs carolynvs deleted the run-xbuild-on-master branch October 4, 2018 21:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. LGTM1 LGTM2 size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants