This repository has been archived by the owner on May 6, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 382
Verify builds on all platforms on master #2096
Merged
jboyd01
merged 1 commit into
kubernetes-retired:master
from
carolynvs:run-xbuild-on-master
Jun 11, 2018
Merged
Verify builds on all platforms on master #2096
jboyd01
merged 1 commit into
kubernetes-retired:master
from
carolynvs:run-xbuild-on-master
Jun 11, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid realizing too late (when we tag a release) that one of the supported architectures has a build problem. I didn't want to slow down all the PR builds, so I'm only doing this for master.
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Jun 5, 2018
MHBauer
approved these changes
Jun 5, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
LGTM
carolynvs
force-pushed
the
run-xbuild-on-master
branch
from
June 6, 2018 00:39
80aa1ea
to
2b162a0
Compare
I have verified that the new xbuild stage works in this PR, and removed the test commit. |
carolynvs
changed the title
[WIP]Verify builds on all platforms on master
Verify builds on all platforms on master
Jun 6, 2018
testing |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
carolynvs
pushed a commit
to carolynvs/service-catalog
that referenced
this pull request
Jun 14, 2018
carolynvs
pushed a commit
to carolynvs/service-catalog
that referenced
this pull request
Jun 14, 2018
…retired#2096)"" This reverts commit 5eb62f5.
Merged
kikisdeliveryservice
pushed a commit
to kikisdeliveryservice/service-catalog
that referenced
this pull request
Jun 29, 2018
This is to avoid realizing too late (when we tag a release) that one of the supported architectures has a build problem. I didn't want to slow down all the PR builds, so I'm only doing this for master.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
Indicates that a PR is ready to be merged.
LGTM1
LGTM2
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid realizing too late (when we tag a release) that one of the supported architectures has a build problem. I didn't want to slow down all the PR builds, so I'm only doing this for master.