Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Improve svcat's "x is required" error messages & make them consistent #2038

Merged

Conversation

luksa
Copy link
Contributor

@luksa luksa commented May 16, 2018

For example, svcat provision clearly specifies what name is required:

# svcat provision
Error: an instance name is required

But others return slightly less-descriptive errors like this:

# svcat deprovision
Error: name is required 

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 16, 2018
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 16, 2018
@jboyd01
Copy link
Contributor

jboyd01 commented May 16, 2018

I restarted the travis job: The job exceeded the maximum time limit for jobs, and has been terminated.

Copy link
Contributor

@carolynvs carolynvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for making the error messages more clear! 👍

@jboyd01 jboyd01 added the LGTM2 label May 16, 2018
@jboyd01 jboyd01 merged commit 9678178 into kubernetes-retired:master May 16, 2018
@luksa luksa deleted the svcat_consistent_error_messages branch May 17, 2018 12:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants