This repository has been archived by the owner on May 6, 2022. It is now read-only.
Update catalog charts README configuration #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
carolynvs
suggested changes
Mar 9, 2018
charts/catalog/README.md
Outdated
| | `apiserver.audit.activated` | If true, enables the use of audit features via this chart. | `false` | | ||
| | `apiserver.audit.logPath` | If specified, audit log goes to specified path. | `"/tmp/service-catalog-apiserver-audit.log"` | | ||
| | `apiserver.serviceAccount` | Service account. | `service-catalog-apiserver` | | ||
| | `apiserver.serveOpenAPISpec` | If specified, audit log goes to specified path. | `"/tmp/service-catalog-apiserver-audit.log"` | |
There was a problem hiding this comment.
This should be "if true, makes the API server serve the OpenAPI schema"
There was a problem hiding this comment.
@carolynvs Done, sorry about that! Please have another look, thanks!
lilic
force-pushed
the
lili/fix-config-docs
branch
from
854ad20 to
7416557
Compare
jeremyrickard
pushed a commit
to jeremyrickard/service-catalog
that referenced
this pull request
Mar 13, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemed to be out of sync with the
values.yamlfile. I just more or less copied over the same description that was in that file.cc @pmorie