On provision, service-catalog doesn't write the description or status code of an unexpected broker response

[arschles]

If a broker doesn't return an expected response code, it writes nothing into the status.conditions field of the newly created Instance. It should at least write the status code returned by the broker server.

Repro steps:

1. Follow all steps in this demo repository through "View Service Classes"
2. Follow steps in "Provision a New Service"
3. Follow steps in "Provision a New Service" again
4. Notice that the 2nd Instance has an empty conditions field, while the broker server failed and the controller logs showed an error response from the broker server

Note that service-catalog currently implements a proper client for the OSB API spec, but silently failing for brokers that are not 100% adherent to the spec presents a very difficult user experience. I'd like for at least the status code and the response body to be written into a condition in the failed Instance's status.conditions field.

[MHBauer]

I read through #925 & #915 and I am missing some higher level understanding to get what is being addressed here.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[mszostok]

/remove-lifecycle rotten
/lifecycle frozen

[mrbobbytables]

This project is being archived, closing open issues and PRs.
Please see this PR for more information: kubernetes/community#6632