Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Support plan updates for Instances #748

Closed
pmorie opened this issue Apr 25, 2017 · 5 comments
Closed

Support plan updates for Instances #748

pmorie opened this issue Apr 25, 2017 · 5 comments
Labels
api broker-api-spec-compliance
Milestone
0.1.0

Comments

@pmorie
Copy link
Contributor

pmorie commented Apr 25, 2017

We currently do not correctly support plan update to Instances correctly from what I can tell. We should:

  1. Only allow changes to the PlanName field of InstanceSpec if the ServiceClass is plan-updatable (sounds like an admission controller to me)
  2. Send the prior plan ID correctly (this is something that it is not yet obvious to me how we should solve in the API - seems like the admission controller could be responsible for setting a field, perhaps in an UpdateParameters field on the spec that the controller could then clear)
@pmorie pmorie added this to the 0.1.0 milestone Apr 25, 2017
@pmorie
Copy link
Contributor Author

pmorie commented Apr 25, 2017

Adding this for 0.1.0 because it seems like it should be done before beta.

@pmorie pmorie mentioned this issue May 12, 2017
Closed
@duglin duglin added the api label May 13, 2017
@arschles
Copy link
Contributor

We believe that this can be solved w/o any API surface changes, so I am moving this out to 1.0.0

@arschles arschles modified the milestones: 1.0.0, 0.1.0 May 15, 2017
@pmorie
Copy link
Contributor Author

pmorie commented Jun 19, 2017

Part of this change: #869

This was referenced Aug 3, 2017
Closed
Closed
@pmorie pmorie modified the milestones: 0.1.0, 1.0.0 Aug 15, 2017
@pmorie
Copy link
Contributor Author

pmorie commented Aug 15, 2017

Setting the milestone to 0.1.0 because it was scoped to beta in #1098

@staebler staebler mentioned this issue Sep 28, 2017
Merged
@pmorie
Copy link
Contributor Author

pmorie commented Oct 6, 2017

Closed by #1289

@pmorie pmorie closed this as completed Oct 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
api broker-api-spec-compliance
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
3 participants
@arschles @pmorie @duglin