Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Add auth to the fake broker server, and test it #571

Closed
arschles opened this issue Mar 16, 2017 · 14 comments
Closed

Add auth to the fake broker server, and test it #571

arschles opened this issue Mar 16, 2017 · 14 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. testing
Milestone
1.0.0

Comments

@arschles
Copy link
Contributor

Make sure that the OSB client properly sends auth headers on all requests.
@arschles arschles added this to the MVP 3 milestone Mar 16, 2017
@MHBauer
Copy link
Contributor

MHBauer commented Mar 16, 2017

Currently it does not check the contents, but it does check for presence or absence. Absent headers will fail tests by returning 404.

@pmorie pmorie modified the milestones: 0.0.3, 0.0.2 Apr 7, 2017
@pmorie
Copy link
Contributor

pmorie commented Apr 7, 2017

Moving to 0.0.3 because this isn't done yet.

@arschles
Copy link
Contributor Author

This looks related to #533

@arschles
Copy link
Contributor Author

#533 is related to this, as that includes other improvements to the fake broker server

@pmorie pmorie modified the milestones: 0.0.4, 0.0.3 Apr 14, 2017
@pmorie
Copy link
Contributor

pmorie commented Apr 14, 2017

Moving to next alpha release for now. We probably need someone to own all of these related issues.

@arschles
Copy link
Contributor Author

I am moving this to the beta cycle along with #533

@arschles arschles modified the milestones: 0.1.0, 0.0.4 Apr 21, 2017
@arschles
Copy link
Contributor Author

arschles commented May 12, 2017 •
edited
Loading

I am removing a milestone from this issue. Also, it's not clear if this will still help our testing. @pmorie can you comment here?

@arschles arschles removed this from the 0.1.0 milestone May 12, 2017
@duglin
Copy link
Contributor

duglin commented Jul 9, 2017

I'm tagging this a v1.0 because it seems to me that if we don't have a fake broker that supports checking auth then we're not fully testing the most comment flow. We should test w/ and w/o auth BTW.

@duglin duglin added this to the 1.0.0 milestone Jul 9, 2017
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 21, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 21, 2019
@jberkhahn jberkhahn removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 23, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 20, 2019
@mszostok
Copy link
Contributor

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Sep 20, 2019
@mrbobbytables
Copy link

This project is being archived, closing open issues and PRs.
Please see this PR for more information: kubernetes/community#6632

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. testing
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
9 participants
@arschles @pmorie @duglin @jberkhahn @mrbobbytables @MHBauer @mszostok @k8s-ci-robot @fejta-bot