Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Add DefaultBindParameters to plans #2348

Closed
carolynvs opened this issue Sep 19, 2018 · 6 comments
Closed

Add DefaultBindParameters to plans #2348

carolynvs opened this issue Sep 19, 2018 · 6 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@carolynvs
Copy link
Contributor

carolynvs commented Sep 19, 2018

Similar to how we added DefaultProvisionParameters to plans in #2282, we also want the same type of functionality but for the parameters on ServiceBinding resources.

See the proposal for additional context and details: https://github.com/carolynvs/service-catalog/blob/default-service-plan-proposal/docs/proposals/default-service-plans.md#binding-with-defaults. The scope of this issue is only the changes to the resource definitions and the controller, not svcat.

An operator can edit a plan and define defaultBindParameters:

apiVersion: servicecatalog.k8s.io/v1beta1
kind: ClusterServicePlan
metadata:
  name: "427559f1-bf2a-45d3-8844-32374a3e58aa"
spec:
  clusterServiceClassRef:
    name: "997b8372-8dac-40ac-ae65-758b4a5075a5"
  externalName: basic50
  # spec truncated for clarity
  defaultBindParameters:
    user: reader
    hasExec: false 

Then when someone creates a binding for that plan, the parameters from the plan are merged with the parameters (if any) on the binding:

apiVersion: servicecatalog.k8s.io/v1beta1
kind: ServiceBinding
metadata:
  name: mydb-admin
spec:
  instanceRef:
    name: mydb
  parameters:
    user: admin

The final ServiceBinding that is used to for the bind operation with the broker:

apiVersion: servicecatalog.k8s.io/v1beta1
kind: ServiceBinding
metadata:
  name: mydb-admin
spec:
  instanceRef:
    name: mydb
  parameters:
    user: admin
    hasExec: false
@carolynvs carolynvs added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 19, 2018
@carolynvs carolynvs added this to the Default Parameters milestone Sep 19, 2018
@carlory
Copy link
Contributor

carlory commented Oct 24, 2018

#dibs

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2019
@jberkhahn jberkhahn removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 23, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 20, 2019
@mszostok
Copy link
Contributor

mszostok commented Oct 3, 2019

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Oct 3, 2019
@mrbobbytables
Copy link

This project is being archived, closing open issues and PRs.
Please see this PR for more information: kubernetes/community#6632

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants