Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

[svcat] Bind command should accept a JSON string as parameters #1871

Closed
maqiuyujoyce opened this issue Mar 23, 2018 · 2 comments · Fixed by #1889
Closed

[svcat] Bind command should accept a JSON string as parameters #1871

maqiuyujoyce opened this issue Mar 23, 2018 · 2 comments · Fixed by #1889
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. svcat

Comments

@maqiuyujoyce
Copy link

Users should be able to specify a flag that receives a JSON string containing the binding parameters. Not all the parameters can be represented as KEY=VALUE pairs, so providing this new option will be very useful.
@carolynvs carolynvs added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. svcat labels Mar 26, 2018
@carolynvs
Copy link
Contributor

Oops! Thank you for bringing this up! 👍

I see now that we only added the new --params-json flag to svcat provision and not also svcat bind. Essentially we need to do the same work from #1785 but for the bind command.

@n3wscott n3wscott self-assigned this Mar 29, 2018
@n3wscott
Copy link
Contributor

#dibs

@n3wscott n3wscott mentioned this issue Mar 29, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. svcat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Svcat bind params now supports --params-json n3wscott/service-catalog
3 participants
@carolynvs @n3wscott @maqiuyujoyce