Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Add wait flags to svcat commands #1736

Closed
5 of 9 tasks
carolynvs opened this issue Feb 12, 2018 · 9 comments
Closed
5 of 9 tasks

Add wait flags to svcat commands #1736

carolynvs opened this issue Feb 12, 2018 · 9 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. svcat
Milestone

Comments

@carolynvs
Copy link
Contributor

carolynvs commented Feb 12, 2018

A pretty common scenario is that I want to execute an operation (provision/bind) and then wait for it to be ready to use. I think it would be very dev friendly to support those with flags, instead of driving people to use bash-foo:

  • svcat OP [--timeout=5m] waits for the instance to be provisioned or fail. Useful for simple scripts that aren't performing concurrent tasks. When a timeout is not set, wait some long but not infinite duration.
  • svcat OP --no-wait does not wait for the operation to complete (current behavior). The status will be empty in the output. Useful when you want to chain multiple commands and wait for them later.
  • svcat get RESOURCE --watch mimics the functionality of kubectl. Useful for those who didn't use --wait on the original OP or are watching an operation they didn't initiate from svcat.
  • Use a slight backoff instead of polling at a set interval. We shouldn't be so aggressive on the backoff that we aren't checking status for huge spans of time. Just enough that we aren't polling every second the entire time.
  • svcat provision --wait
  • svcat bind --wait
  • svcat deprovision --wait
  • svcat unbind INSTANCE --wait waits for all bindings associated with the instance to be deleted.
  • svcat unbind --name BINDING --wait
  • svcat get instance NAME --wait waits until the specified instance's current operation is complete. Useful when you didn't watch on provision and want to check in later.
  • svcat get binding NAME --wait, same as above but for bindings.
  • svcat sync broker NAME --wait, waits for the sync to complete.
  • svcat touch instance NAME --wait waits for the instance to be processed by the svc-cat controller.

Examples:

svcat provision mysql

svcat bind mysql --no-wait
svcat get binding mysql --watch

Migrated from Azure/service-catalog-cli#89

@duglin
Copy link
Contributor

duglin commented Feb 12, 2018

I would almost think it should be the opposite - make the default "wait" and add some "--no-wait" flag for the less common cases where you don't want to wait.

@carolynvs
Copy link
Contributor Author

carolynvs commented Feb 12, 2018

I agree! Not sure why I picked it to work that way when I first created that issue a while back but I'd prefer that svcat do what most people probably want by default.

I've updated the OP to switch the default behavior to waiting.

@carolynvs carolynvs added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 6, 2018
@carolynvs carolynvs self-assigned this Apr 24, 2018
@carolynvs
Copy link
Contributor Author

#dibs

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 23, 2019
@jberkhahn jberkhahn removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 20, 2019
@mszostok
Copy link
Contributor

/remove-lifecycle rotten
/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Sep 20, 2019
@carolynvs carolynvs removed their assignment Feb 19, 2020
@carolynvs
Copy link
Contributor Author

/unassign

@mrbobbytables
Copy link

This project is being archived, closing open issues and PRs.
Please see this PR for more information: kubernetes/community#6632

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. svcat
Projects
None yet
Development

No branches or pull requests

7 participants