We should retry Provisioning/Binding when the user corrects the spec

[kibbles-n-bytes]

For example, if a user makes a mistake in their instance spec and the provision fails, often they assume they can edit the resource to fix the mistake and the provision will retry. It's a painful flow to have to delete the resource, make the correction, and recreate the resource. We should make things as easy as possible for the user and let them correct their provision mistake within the same resource.

Internally, we should orphan mitigate and retry provisioning/binding with the new properties. Instead of judging whether a reconciliation is an update or an add based on ReconciledGeneration, we can use whether ExternalProperties is set.

[dmitri-d]

Apologies if I'm missing something blatantly obvious.

I just tried updating a spec (clusterServicePlanExternalName, using patch) for a ServiceInstance that failed to provision originally. It worked and the service instance was successfully provisioned after the update. Also worked for adding a new parameter, but didn't work for updating an existing parameter (not sure why atm).

What is the scenario that this is meant to address?

[nilebox]

We have noticed the same issue with retrying after connection timeout or 400 Bad Request. Agree that we should be able to retry, see a table in #1715

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.