Skip to content
This repository has been archived by the owner on Oct 16, 2018. It is now read-only.

tasks-inject-data-application-environment-variable-expose-pod-informa… #331

Merged
merged 1 commit into from
Apr 1, 2018
Merged

tasks-inject-data-application-environment-variable-expose-pod-informa… #331

merged 1 commit into from
Apr 1, 2018

Conversation

chentao1596
Copy link
Contributor

@chentao1596 chentao1596 commented Mar 29, 2018 •
edited
Loading

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 29, 2018
markthink
markthink reviewed Apr 1, 2018
View reviewed changes
Copy link
Contributor

@markthink markthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the review looks good to me.

@markthink markthink merged commit c37cc85 into kubernetes-retired:master Apr 1, 2018
@chentao1596 chentao1596 mentioned this pull request Oct 12, 2018
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markthink markthink markthink left review comments

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chentao1596 @markthink @k8s-ci-robot @chentao11596