This repository has been archived by the owner on Apr 22, 2020. It is now read-only.
Fix race condition when waiting for kubeconfig. #357
Merged
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If WAIT_FOR_KUBECONFIG is set and the cluster comes up very quickly so that first ssh call succeeds, then the output from ssh's initialization (generating keys, showing fingerprints/randomart, etc.) can get included at the start of the kubeconfig.json file, rendering it invalid. To alleviate this, echo a marker to indicate the start of the file so we can delete this noise.
This was referenced Mar 16, 2017
|
/assign @mikedanese |
k8s-ci-robot
added
the
cncf-cla: yes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
WAIT_FOR_KUBECONFIGis set and the cluster comes up very quickly so that first ssh call succeeds, then the output from ssh's initialization (generating keys, showing fingerprints/randomart, etc.) can get included at the start of thekubeconfig.jsonfile, rendering it invalid.To alleviate this, echo a marker to indicate the start of the file so we can delete this noise.
CC @mikedanese