This repository has been archived by the owner on Oct 21, 2020. It is now read-only.
Fix provisioning for >=1.5 to recognize annotation as authoritative #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
size/L
k8s-ci-robot
added
the
cncf-cla: yes
|
/lgtm |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Dec 21, 2017
Automatic merge from submit-queue (batch tested with PRs 57434, 57221, 57417, 57474, 57481). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update nfsprovisioner image to v1.0.9 to fix annotation race with pv controller fix #55780 . Summary: the provisioner must wait for the pv controller's annotation to be set as described by the 'protocol' doc, fail to wait and the pv controller may not be ready. The relevant change to the image was kubernetes-retired/external-storage#521 ```release-note NONE ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug uncovered by kubernetes/kubernetes#55780 (comment)
In Kube >=1.5, the annotation is supposed to be the authoritative/only source of truth about whether to provision for a given volume.
The tests now set the annotation by default since it is what the kube pv controller would do.