Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

[mungegithub] Set up an E2E test for the bot #1516

Closed
foxish opened this issue Aug 11, 2016 · 3 comments
Closed

[mungegithub] Set up an E2E test for the bot #1516

foxish opened this issue Aug 11, 2016 · 3 comments
Assignees

Comments

@foxish
Copy link
Contributor

foxish commented Aug 11, 2016

With the right use of fakes and mocks, we should be able to setup a comprehensive e2e test for the bot, so that we can make changes more confidently. This should go hand in hand with the canary style of deployment, and a standard deployment plan for the submit-queue.

@foxish
Copy link
Contributor Author

foxish commented Aug 11, 2016

We should probably move to the dedicated kubernetes/pr-bot repository first, before we do this. #762 (comment)

@apelisse
Copy link
Contributor

Yes, we could improve that, it would be very sweet.

@foxish foxish changed the title [mungegithub ] Set up an E2E test for the bot [mungegithub] Set up an E2E test for the bot Aug 11, 2016
@foxish
Copy link
Contributor Author

foxish commented Jan 20, 2017

This is really hard and I question whether it is worth doing considering how reliant it is on github's API.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants