Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Mergebot merged a PR that had needs-rebase label #1391

Closed
nikhiljindal opened this issue Jul 19, 2016 · 4 comments
Closed

Mergebot merged a PR that had needs-rebase label #1391

nikhiljindal opened this issue Jul 19, 2016 · 4 comments

Comments

@nikhiljindal
Copy link
Contributor

kubernetes/kubernetes#26298 was merged by mergebot even though it had the needs-rebase label.

cc @k8s-oncall as FYI

cc @lavalamp @eparis

@lavalamp
Copy link
Contributor

The PR must not have needed a rebase or it wouldn't have been possible to merge it. Maybe the github API had a hiccup while the merge bot was checking mergability.

@lavalamp
Copy link
Contributor

Or maybe something got rolled back that made it mergable again?

@apelisse
Copy link
Contributor

Yeah, I'm not too worried about this. Maybe the bot would have removed the label if it hadn't been merged?

If it can be merged, it's good if it is.
What would be bad is if it would add the label while it's not necessary?

@eparis
Copy link
Contributor

eparis commented Jul 20, 2016

Agreed, I'm not too worried although this may be a case of #422

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants