Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

Fix golang-ci lint configuration exclude configuration #80

Closed
sbueringer opened this issue May 25, 2021 · 3 comments · Fixed by #90
Closed

Fix golang-ci lint configuration exclude configuration #80

sbueringer opened this issue May 25, 2021 · 3 comments · Fixed by #90
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@sbueringer
Copy link

sbueringer commented May 25, 2021 •
edited
Loading

The exclude configuration Using the variable on range scope (tc)|(rt)|(tt)|(test)|(testcase)|(testCase) in function literal in .golang.ci.yml matches too many findings.

Every finding which contains "rt", "tt", "test", .. is excluded.

For more context:
@sbueringer sbueringer mentioned this issue May 25, 2021
Merged
@christopherhein
Copy link
Contributor

/good-first-issue
/help
/kind cleanup

@k8s-ci-robot
Copy link
Contributor

@christopherhein:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue
/help
/kind cleanup

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels May 25, 2021
@christopherhein
Copy link
Contributor

thanks @sbueringer for opening this.

@christopherhein christopherhein mentioned this issue Jun 8, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Upgrade Golang CI & Fix Lint christopherhein/cluster-api-provider-nested
3 participants
@christopherhein @sbueringer @k8s-ci-robot