Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

⚠️ Change default branch to "main" #47

Closed
13 tasks done
christopherhein opened this issue May 5, 2021 · 10 comments
Closed
13 tasks done

⚠️ Change default branch to "main" #47

christopherhein opened this issue May 5, 2021 · 10 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. wg/naming Categorizes an issue or PR as relevant to WG Naming.
Milestone

Comments

@christopherhein
Copy link
Contributor

christopherhein commented May 5, 2021

Instructions here https://www.kubernetes.dev/resources/rename/

Anytime

Just before rename

  • periodic prowjobs, or any prowjob that mentions the master
  • If a prowjob mentions master in its name, rename the job to not include the branch name
  • If a prowjob calls scripts or code in your repo that explicitly reference master

Finalizing

Post-rename

/kind cleanup
/wg naming

@k8s-ci-robot
Copy link
Contributor

@christopherhein: The provided milestone is not valid for this repository. Milestones in this repository: [next, v0.1.0, v0.1.x]

Use /milestone clear to clear the milestone.

In response to this:

Instructions here https://www.kubernetes.dev/resources/rename/

/kind cleanup
/wg naming
/milestone Next

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. wg/naming Categorizes an issue or PR as relevant to WG Naming. labels May 5, 2021
@christopherhein
Copy link
Contributor Author

/milestone v0.1.x

@k8s-ci-robot k8s-ci-robot added this to the v0.1.x milestone May 5, 2021
@christopherhein
Copy link
Contributor Author

christopherhein commented May 18, 2021

/assign @kubernetes/owners

As per - https://www.kubernetes.dev/resources/rename/#approval

@spiffxp
Copy link

spiffxp commented May 18, 2021

So I see you checked a bunch of boxes but what exactly did you do? Do you have links to PRs or descriptions of why you're good to go?

@christopherhein
Copy link
Contributor Author

christopherhein commented May 18, 2021

@spiffxp we didn't have a lot of work since this is a relatively new repo, we only have one Prow job which was added recently with this issue in mind - https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api-provider-nested/cluster-api-provider-nested-presubmits.yaml#L10 and in those the scripts that are called act solely on the branch that was pulled. Both branch_protection and milestone_applier haven't been configured yet.

Additionally, We discussed this on today's CAPN Office hours as well - https://www.youtube.com/watch?v=-bbUzYKHFls&t=5s to pre-emptively get folks ready for when the change goes into effect.

@spiffxp
Copy link

spiffxp commented May 19, 2021

@christopherhein
Copy link
Contributor Author

christopherhein commented May 19, 2021

Good catch, thank you, I'll get that fixed up after the branch change.

@christopherhein
Copy link
Contributor Author

Branch has been changed in the Githuh UI and not is tracking the main branch. https://github.com/kubernetes-sigs/cluster-api-provider-nested/tree/main

@christopherhein christopherhein changed the title Change default branch to "main" ⚠️ Change default branch to "main" May 21, 2021
@christopherhein
Copy link
Contributor Author

/close
Thanks folks for all your help on this! 🎉
https://groups.google.com/g/kubernetes-sig-cluster-lifecycle/c/Woe731ONmBc

@k8s-ci-robot
Copy link
Contributor

@christopherhein: Closing this issue.

In response to this:

/close
Thanks folks for all your help on this! 🎉
https://groups.google.com/g/kubernetes-sig-cluster-lifecycle/c/Woe731ONmBc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. wg/naming Categorizes an issue or PR as relevant to WG Naming.
Projects
None yet
Development

No branches or pull requests

3 participants