-
Notifications
You must be signed in to change notification settings - Fork 67
⚠️ Change default branch to "main" #47
Comments
@christopherhein: The provided milestone is not valid for this repository. Milestones in this repository: [ Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone v0.1.x |
/assign @kubernetes/owners As per - https://www.kubernetes.dev/resources/rename/#approval |
So I see you checked a bunch of boxes but what exactly did you do? Do you have links to PRs or descriptions of why you're good to go? |
@spiffxp we didn't have a lot of work since this is a relatively new repo, we only have one Prow job which was added recently with this issue in mind - https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/cluster-api-provider-nested/cluster-api-provider-nested-presubmits.yaml#L10 and in those the scripts that are called act solely on the branch that was pulled. Both Additionally, We discussed this on today's CAPN Office hours as well - https://www.youtube.com/watch?v=-bbUzYKHFls&t=5s to pre-emptively get folks ready for when the change goes into effect. |
You'll want to take care of https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/fefd2138922b0d24a7ebe8c569cef0bc2f42e242/Makefile#L147 But +1 as a github admin to go ahead |
Good catch, thank you, I'll get that fixed up after the branch change. |
Branch has been changed in the Githuh UI and not is tracking the |
/close |
@christopherhein: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Instructions here https://www.kubernetes.dev/resources/rename/
Anytime
Just before rename
Finalizing
head
to track mainPost-rename
If the milestone_applier prow config references the master branch, remove it from the config./kind cleanup
/wg naming
The text was updated successfully, but these errors were encountered: