until there is an auth plan tls testing should support insecure #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike Brown <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
Discussed with @tallclair, today the behavior of streaming authentication is not defined in CRI yet. And at least apiserver on GCE doesn't actually validate the certificate. I think it makes sense to skip the certificate validation in CRI validation test for now, until this is defined in CRI. /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over on containerd/cri#681 we added support to containerd/cri and expected that critools would support tls without auth. However, the following error occurs when attempt to run validation:
Mar 19 20:49:18.310: INFO: Unexpected error occurred: error sending request: Post https://10.20.0.36:10010/attach/Vy2abuwM: x509: certificate signed by unknown authority
This commit relaxes the certificate requirement on the server, before an encrypted stream can be started from crictl and critest validate.
We should probably discuss, and/or open an issue to discuss, security requirements for streaming for the CRI API.
@Random-Liu
Signed-off-by: Mike Brown [email protected]