Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid api-conventions URL link #258

Closed
wants to merge 1 commit into from
Closed

Invalid api-conventions URL link #258

wants to merge 1 commit into from

Conversation

c3y1huang
Copy link

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:
Original URL link is invalid.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. labels Feb 18, 2020
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: c3y1huang
To complete the pull request process, please assign xing-yang
You can assign the PR to them by writing /assign @xing-yang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 18, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @c3y1huang. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2020
xing-yang
xing-yang reviewed Feb 18, 2020
View reviewed changes
config/crd/snapshot.storage.k8s.io_volumesnapshotclasses.yaml Outdated
@@ -27,7 +27,8 @@ spec:
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#resources'
internal value, and may reject unrecognized values.
More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are generated automatically by running hack/update-crd.sh so we are not supposed to modify them manually.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted URL update for CRDs.

@c3y1huang c3y1huang force-pushed the c3y1/cleanup/update-api-conventions-link branch from 6b9d654 to 50ed4fd Compare February 18, 2020 02:22
@c3y1huang c3y1huang requested a review from xing-yang February 18, 2020 02:41
@xing-yang
Copy link
Collaborator

@yuxiangqian PTAL.

@xing-yang
Copy link
Collaborator

CI failed because you also have to update generated code after modifying types.go.

Take a look of the following issue. Generating code is getting complicated after we changed the package path for v2:
#239 (comment)

@c3y1huang c3y1huang force-pushed the c3y1/cleanup/update-api-conventions-link branch from 50ed4fd to b2239a2 Compare February 19, 2020 01:15
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 19, 2020
@c3y1huang
Invalid api-conventions link
a8c587a 
Signed-off-by: Chin-Ya Huang <[email protected]>
@c3y1huang c3y1huang force-pushed the c3y1/cleanup/update-api-conventions-link branch from b2239a2 to a8c587a Compare February 19, 2020 01:16
@c3y1huang
Copy link
Author

c3y1huang commented Feb 19, 2020 •
edited
Loading

CI failed because you also have to update generated code after modifying types.go.

Take a look of the following issue. Generating code is getting complicated after we changed the package path for v2:
#239 (comment)

Thanks @xing-yang , CI failed due to vendor changes. Don't know what I was thinking :-/. Revert to address.
PTAL.

@xing-yang
Copy link
Collaborator

Just noticed that this other PR (#256) which was submitted a few days earlier than this PR already contains changes in this PR. Let's put this PR on hold for now, wait until the other PR is merged, and then see if there're any additional things that need to be addressed.

@humblec
Copy link
Contributor

humblec commented May 15, 2020 •
edited
Loading

@c3y1huang the PR changs intended here already got in via #260 , unless if some other changes are planned with this PR, I believe we could close this one.. Thanks! @xing-yang what do you think ?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 13, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 12, 2020
@k8s-ci-robot
Copy link
Contributor

@c3y1huang: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 12, 2020
@c3y1huang c3y1huang closed this Sep 14, 2020
TerryHowe added a commit to TerryHowe/external-snapshotter that referenced this pull request Oct 24, 2024
@TerryHowe
Squashed 'release-tools/' changes from 988496a1..227577e0
76c97d4 
227577e0 Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection
e1ceee28 Always enable race detection while running tests

git-subtree-dir: release-tools
git-subtree-split: 227577e00e93c3db4e732df1a71e37676fa33bfd
huww98 added a commit to huww98/external-snapshotter that referenced this pull request Nov 22, 2024
@huww98
Squashed 'release-tools/' changes from 988496a1f..e31de525b
9f167db 
e31de525b Merge pull request kubernetes-csi#261 from huww98/golang
fd153a9e2 Bump golang to 1.23.1
a8b3d0504 pull-test.sh: fix "git subtree pull" errors
227577e00 Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection
e1ceee287 Always enable race detection while running tests

git-subtree-dir: release-tools
git-subtree-split: e31de525b39d99e762c2b0fc825576ec623fa1a6
AndrewSirenko pushed a commit to AndrewSirenko/external-snapshotter that referenced this pull request Dec 10, 2024
@huww98 @AndrewSirenko
Squashed 'release-tools/' changes from 988496a1f..e31de525b
9394e58 
e31de525b Merge pull request kubernetes-csi#261 from huww98/golang
fd153a9e2 Bump golang to 1.23.1
a8b3d0504 pull-test.sh: fix "git subtree pull" errors
227577e00 Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection
e1ceee287 Always enable race detection while running tests

git-subtree-dir: release-tools
git-subtree-split: e31de525b39d99e762c2b0fc825576ec623fa1a6
AndrewSirenko added a commit to AndrewSirenko/external-snapshotter that referenced this pull request Dec 10, 2024
@AndrewSirenko
Squashed 'release-tools/' changes from 988496a1..98f23071
27d661c 
98f23071 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version
e9d8712d Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root
faf79ff6 Remove --kube-root deprecated kind argument
734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch
f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain
3c8d966f Treat main branch as equivalent to master branch
e31de525 Merge pull request kubernetes-csi#261 from huww98/golang
fd153a9e Bump golang to 1.23.1
a8b3d050 pull-test.sh: fix "git subtree pull" errors
6b05f0fc use new GOTOOLCHAIN env to manage go version
18b6ac6d chore: update CSI driver version to 1.15
227577e0 Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection
e1ceee28 Always enable race detection while running tests

git-subtree-dir: release-tools
git-subtree-split: 98f23071d946dd3de3188a7e1f84679067003162
AndrewSirenko added a commit to AndrewSirenko/external-snapshotter that referenced this pull request Dec 10, 2024
@AndrewSirenko
Squashed 'release-tools/' changes from 988496a1..406a79ac
e2595d3 
406a79ac Merge pull request kubernetes-csi#267 from huww98/gomodcache
9cec273d Set GOMODCACHE to avoid re-download toolchain
98f23071 Merge pull request kubernetes-csi#260 from TerryHowe/update-csi-driver-version
e9d8712d Merge pull request kubernetes-csi#259 from stmcginnis/deprecated-kind-kube-root
faf79ff6 Remove --kube-root deprecated kind argument
734c2b95 Merge pull request kubernetes-csi#265 from Rakshith-R/consider-main-branch
f95c855b Merge pull request kubernetes-csi#262 from huww98/golang-toolchain
3c8d966f Treat main branch as equivalent to master branch
e31de525 Merge pull request kubernetes-csi#261 from huww98/golang
fd153a9e Bump golang to 1.23.1
a8b3d050 pull-test.sh: fix "git subtree pull" errors
6b05f0fc use new GOTOOLCHAIN env to manage go version
18b6ac6d chore: update CSI driver version to 1.15
227577e0 Merge pull request kubernetes-csi#258 from gnufied/enable-race-detection
e1ceee28 Always enable race detection while running tests

git-subtree-dir: release-tools
git-subtree-split: 406a79acf021b5564108afebeea7d0ed44648d3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali Awaiting requested review from saad-ali

@yuxiangqian yuxiangqian Awaiting requested review from yuxiangqian

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@c3y1huang @k8s-ci-robot @xing-yang @humblec @fejta-bot